-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add daemonset affinity and tolerations to Helm chart #2476
add daemonset affinity and tolerations to Helm chart #2476
Conversation
Hi @gsstuart. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
==========================================
- Coverage 45.50% 41.85% -3.65%
==========================================
Files 79 109 +30
Lines 7782 16013 +8231
==========================================
+ Hits 3541 6702 +3161
- Misses 4099 8814 +4715
- Partials 142 497 +355 |
Please rebase to fix the CI. |
50fb5b3
to
be29335
Compare
rebase complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, gsstuart The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows spod daemonset affinity and tolerations to be set via the Helm chart.
Which issue(s) this PR fixes:
Fixes #2471
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?