Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifying approach to versioning #492

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Clarifying approach to versioning #492

merged 1 commit into from
Dec 9, 2020

Conversation

robscott
Copy link
Member

@robscott robscott commented Dec 4, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This clarifies our approach to versioning. Much of this is based on our conversation at the community meeting earlier this week.

Which issue(s) this PR fixes:
This is related to #447 but does not provide a long term solution for v1alpha2.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bowei and jpeach December 4, 2020 21:54
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2020
@robscott
Copy link
Member Author

robscott commented Dec 4, 2020

/cc @hbagdi

@k8s-ci-robot k8s-ci-robot requested a review from hbagdi December 4, 2020 21:54
hbagdi
hbagdi reviewed Dec 7, 2020
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2020
@danehans
Copy link
Contributor

danehans commented Dec 9, 2020

Commit 7dbb1e8 resolves #492 (comment).

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit a705d18 into kubernetes-sigs:master Dec 9, 2020
@robscott robscott mentioned this pull request Dec 10, 2020
Merged
@robscott robscott deleted the release-versioning branch January 8, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi hbagdi left review comments

@bowei bowei Awaiting requested review from bowei

@jpeach jpeach Awaiting requested review from jpeach

Assignees

@danehans danehans

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robscott @k8s-ci-robot @danehans @hbagdi