Increasing max length of ForwardTo from 4 to 16 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
hbagdi
approved these changes
Dec 7, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbagdi, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
As identified in #481, the initial validation on the length of ForwardTo was too restrictive. Knative has some compelling use cases for 10+ ForwardTo statements. Further discussion showed that 16 would be a reasonable upper limit for them. I've also taken some time to ensure that this would also be possible for common proxies such as nginx, haproxy, and envoy. The primary reason for an upper limit here is to ensure we have no unbounded lists in our API. Increasing this limit does not appear to be an issue for any implementations I'm aware of. If it is, please let me know.
Which issue(s) this PR fixes:
Fixes #481
Does this PR introduce a user-facing change?:
/cc @danehans @hbagdi