Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to golang 1.20 #106

Merged
merged 1 commit into from
May 2, 2023
Merged

Update to golang 1.20 #106

merged 1 commit into from
May 2, 2023

Conversation

jsturtevant
Copy link
Contributor

updating to use golang 1.20

/assign @marosset

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from jayunit100 April 28, 2023 18:31
@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from marosset April 28, 2023 18:31
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2023
@jsturtevant
Copy link
Contributor Author

this built when I was working with the deps update in #105. I will rebase this once that merges.

@jsturtevant jsturtevant force-pushed the update-golang branch 2 times, most recently from e7c0d4b to 1a22509 Compare May 1, 2023 23:43
@jsturtevant
Update to golang 1.20
1a22509 
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@jsturtevant
Copy link
Contributor Author

this built when I was working with the deps update in #105. I will rebase this once that merges.

yaml formatting 🤮 actions/setup-go#326

@marosset
Copy link
Contributor

marosset commented May 2, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fa115c8 into kubernetes-sigs:master May 2, 2023
@marosset marosset mentioned this pull request Aug 22, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@marosset marosset Awaiting requested review from marosset

Assignees

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsturtevant @marosset @k8s-ci-robot