Cloudbuild fixups #29
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
marosset
force-pushed
the
cloudbuild-fixups
branch
from
ee3851d to
065cc89
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/assign @knabben @jsturtevant |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| output="type=docker,dest=./output/export.tar" | ||
|
|
||
| if [[ "$push" == "1" ]]; then | ||
| output="type=registry" |
There was a problem hiding this comment.
did you mean to drop this? looks like make sets this value
There was a problem hiding this comment.
That was intentional.
Since we want to push job to push a latest tag I thought it made more sense to output it to a local file, import the image, then push it with both tags.
If I push it directly to the repository in the build step we'd need to pull the image to tag it and then push it again.
There was a problem hiding this comment.
see the end of the script.
Happy to make more changes if this workflow isn't ideal
There was a problem hiding this comment.
see how it works now. Thanks!
Fixes #7