added unit test with regional MIG

kubernetes · Mar 13, 2024 · 4a38f69 · 4a38f69
1 parent f8b4727
commit 4a38f69
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/cluster-autoscaler/cloudprovider/gce/mig_info_provider_test.go b/cluster-autoscaler/cloudprovider/gce/mig_info_provider_test.go
@@ -852,7 +852,13 @@ func TestGetMigInstanceTemplateName(t *testing.T) {
 	instanceGroupManager := &gce.InstanceGroupManager{
 		Zone:             mig.GceRef().Zone,
 		Name:             mig.GceRef().Name,
-		InstanceTemplate: templateName,
+		InstanceTemplate: "https://www.googleapis.com/compute/v1/projects/test-project/global/instanceTemplates/template-name",
+	}
+
+	instanceGroupManagerRegional := &gce.InstanceGroupManager{
+		Zone:             mig.GceRef().Zone,
+		Name:             mig.GceRef().Name,
+		InstanceTemplate: "https://www.googleapis.com/compute/v1/projects/test-project/regions/us-central1/instanceTemplates/template-name",
 	}
 
 	testCases := []struct {
@@ -861,6 +867,7 @@ func TestGetMigInstanceTemplateName(t *testing.T) {
 		fetchMigs            func(string) ([]*gce.InstanceGroupManager, error)
 		fetchMigTemplateName func(GceRef) (InstanceTemplateName, error)
 		expectedTemplateName string
+		expectedRegion       bool
 		expectedErr          error
 	}{
 		{
@@ -877,6 +884,12 @@ func TestGetMigInstanceTemplateName(t *testing.T) {
 			fetchMigs:            fetchMigsConst([]*gce.InstanceGroupManager{instanceGroupManager}),
 			expectedTemplateName: templateName,
 		},
+		{
+			name:                 "target size from cache fill, regional",
+			cache:                emptyCache(),
+			fetchMigs:            fetchMigsConst([]*gce.InstanceGroupManager{instanceGroupManagerRegional}),
+			expectedTemplateName: templateName,
+		},
 		{
 			name:                 "cache fill without mig, fallback success",
 			cache:                emptyCache(),