-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aws flaking Unit Tests #1485
Fix aws flaking Unit Tests #1485
Conversation
ddfc454
to
9632052
Compare
@aleksandra-malinowska Looks like create those two issues. Could you help take a look at this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jeffwan Is it only related to 1.2 branch all should be changed on other branches too?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: losipiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@losipiuk Looks like it's disabled since this April and all release after 1.2 can be fixed by cherry-picking this commit. Do you want me to cherry-pick and submit PR against all latest branches? Since there're many branches, how do we deal with this issue normally? Branches:
and also
|
@Jeffwan It would be great if you could cherry pick to at least master. Other CA release branches optionally. Skip vpa please. This need to be separate PRs. We do not have any cp automation. Thanks. |
@losipiuk Thanks for guidance. Will do. |
Cherry-pick of #1485 to 1.12 : Fix aws flaking Unit Tests
Cherry-pick of #1485 to 1.13 : Fix aws flaking Unit Tests
Cherry-pick of #1485 to 1.3 : Fix aws flaking Unit Tests
Cherry-pick of #1485 to master : Fix aws flaking Unit Tests
Looks like this Unit Test blocks several tasks. I notice someone comment this test and I think we can use
MatchedBy
to customize comparison logic.This will resolve #1346 and other dependent issues for 1.2
I run hack/verify-gofmt.sh and found several files are not formatted and then rungofmt -s -w ${filename}
Not sure if that's needed. if not, I will remove second commit