Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws flaking Unit Tests #1485

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Dec 7, 2018

Looks like this Unit Test blocks several tasks. I notice someone comment this test and I think we can use MatchedBy to customize comparison logic.

This will resolve #1346 and other dependent issues for 1.2

I run hack/verify-gofmt.sh and found several files are not formatted and then run gofmt -s -w ${filename} Not sure if that's needed. if not, I will remove second commit

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2018
@Jeffwan Jeffwan force-pushed the fix_aws_flaking_tests branch from ddfc454 to 9632052 Compare December 7, 2018 07:34
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Dec 7, 2018

@aleksandra-malinowska Looks like create those two issues. Could you help take a look at this change?

Copy link
Contributor

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeffwan Is it only related to 1.2 branch all should be changed on other branches too?

@losipiuk
Copy link
Contributor

losipiuk commented Dec 7, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit e740c9e into kubernetes:cluster-autoscaler-release-1.2 Dec 7, 2018
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Dec 7, 2018

@losipiuk Looks like it's disabled since this April and all release after 1.2 can be fixed by cherry-picking this commit. Do you want me to cherry-pick and submit PR against all latest branches? Since there're many branches, how do we deal with this issue normally?

Branches:

  • cluster-autoscaler-release-1.3
  • cluster-autoscaler-release-1.12
  • cluster-autoscaler-release-1.13
  • master

and also

  • vpa-release-0.2
  • vpa-release-0.3

@losipiuk
Copy link
Contributor

losipiuk commented Dec 8, 2018

@Jeffwan It would be great if you could cherry pick to at least master. Other CA release branches optionally. Skip vpa please.

This need to be separate PRs. We do not have any cp automation.

Thanks.

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Dec 8, 2018

@losipiuk Thanks for guidance. Will do.

Jeffwan added a commit to Jeffwan/autoscaler that referenced this pull request Dec 8, 2018
Jeffwan added a commit to Jeffwan/autoscaler that referenced this pull request Dec 8, 2018
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
Cherry-pick of #1485 to 1.12 : Fix aws flaking Unit Tests
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
Cherry-pick of #1485 to 1.13 : Fix aws flaking Unit Tests
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
Cherry-pick of #1485 to 1.3 : Fix aws flaking Unit Tests
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
Cherry-pick of #1485 to master : Fix aws flaking Unit Tests
CodeLingoBot pushed a commit to CodeLingoBot/autoscaler that referenced this pull request Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants