Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick #3649 - Adding functionality to cordon the node before destroying it. This he… #3990

Closed
wants to merge 1 commit into from
Closed

cherry pick #3649 - Adding functionality to cordon the node before destroying it. This he… #3990

wants to merge 1 commit into from

Conversation

ltagliamonte-dd
Copy link

cherry pick #3649 (Adding functionality to cordon the node before destroying it) to 1.18

@atulaggarwal @ltagliamonte-dd
Adding functionality to cordon the node before destroying it. This he…
7b66441 
…lps load balancer to remove the node from healthy hosts (ALB does have this support).

This won't fix the issue of 502 completely as there is some time node has to live even after cordoning as to serve In-Flight request but load balancer can be configured to remove Cordon nodes from healthy host list.
This feature is enabled by cordon-node-before-terminating flag with default value as false to retain existing behavior.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @ltagliamonte-dd!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ltagliamonte-dd
To complete the pull request process, please assign losipiuk after the PR has been reviewed.
You can assign the PR to them by writing /assign @losipiuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and losipiuk April 6, 2021 16:25
@ltagliamonte-dd
Copy link
Author

/assign @losipiuk

@Jeffwan
Copy link
Contributor

Jeffwan commented Apr 6, 2021

Thanks!
You can probably change the title to cherry pick #3649 - your original title instead of explanation at the end of commit which will be truncated.

@ltagliamonte-dd ltagliamonte-dd changed the title Adding functionality to cordon the node before destroying it. This he… cherry pick #3649 - Adding functionality to cordon the node before destroying it. This he… Apr 6, 2021
@ltagliamonte-dd
Copy link
Author

Thanks!
You can probably change the title to cherry pick #3649 - your original title instead of explanation at the end of commit which will be truncated.

Done, Thanks!

elmiko
elmiko reviewed Apr 7, 2021
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if there is any objection to backporting this, but it looks good to me
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@mwielgus
Copy link
Contributor

mwielgus commented Apr 9, 2021

Are there cherrypick prs for more recent branches?

@ltagliamonte-dd
Copy link
Author

Are there cherrypick prs for more recent branch

I don't know if there is a process, but i cherry picked this commits only to the branch i need.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2021
@x13n
Copy link
Member

x13n commented Jul 23, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@x13n: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@x13n
Copy link
Member

x13n commented Jul 23, 2021

1.18 is past the support window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees

@elmiko elmiko

@losipiuk losipiuk

Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ltagliamonte-dd @k8s-ci-robot @Jeffwan @mwielgus @fejta-bot @x13n @elmiko @jbartosik @losipiuk @atulaggarwal