Add azure cloud provider #454
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
@andyzhangx Any ideas of setting up the test on Azure before VMSS is ready? |
| return provider | ||
| } | ||
|
|
||
| func TestBuildAwsCloudProvider(t *testing.T) { |
| } | ||
|
|
||
| func TestIncreaseSize(t *testing.T) { | ||
|
|
| scaleSetCache: make(map[AzureRef]*ScaleSet), | ||
| } | ||
|
|
||
| //(resourceGroupName string, vmScaleSetName string, |
|
|
||
| func (client *VirtualMachineScaleSetsClientMock) Get(resourceGroupName string, | ||
| vmScaleSetName string) (result compute.VirtualMachineScaleSet, err error) { | ||
| fmt.Printf("Called VirtualMachineScaleSetsClientMock.Get(%s,%s)\n", resourceGroupName, vmScaleSetName) |
|
Cool, thank you for this contribution! |
mwielgus
added
area/provider/azure
|
We will also need some documentation explaining how to setup CA on Azure, as a part of this PR. |
|
@mwielgus yep, I'm validating this on Azure now. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
This is because instance.ID is in different in different API calls (e.g. GET and LIST).
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Validated scaling up and down on Azure VMSS (with kubernetes/kubernetes#55833), both work as expected now. @brendandburns @mwielgus @andyzhangx Ready for review now. PTAL. |
|
ping @MaciekPytel @mwielgus Could you take a look the PR? |
|
/lgtm @feiskyer, @andyzhangx I assume that you will be the main contacts for all Azure-related issues and PRs. Neither me nor @MaciekPytel, @aleksandra-malinowska or @bskiba have capacity/capabilities to do Azure-specific reviews, debugging or testing. |
k8s-ci-robot
added
the
lgtm
|
@mwielgus Thanks. Yep, we will be in charge of all Azure related changes. |
Refactor: split out flavor assigment logic
This is the first step of adding Azure cloud provider back (#449 and kubernetes/kubernetes#47511). Mainly changes includes:
Note: Kubernetes Azure cloud provider VMSS support is not finished yet, so this work is tested togather with kubernetes/kubernetes#55833.
And there are more work to do to enable fully azure support, which is tracking at #449.
Closes: #133