Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: wip refactor test utils for building pods and nodes #5932

Closed
wants to merge 11 commits into from
Closed

test: wip refactor test utils for building pods and nodes #5932

wants to merge 11 commits into from

Conversation

vadasambar
Copy link
Member

Signed-off-by: vadasambar surajrbanakar@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR attempts to make our test utils around creating pods and nodes more flexible.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vadasambar
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 6, 2023
@vadasambar vadasambar mentioned this pull request Jul 6, 2023
Merged
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2023
@vadasambar vadasambar mentioned this pull request Jul 6, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023
@vadasambar
test: wip refactor test utils for building pods and nodes
0f06772 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar
refactor(test): use options pattern for all pod related helpers
64639bd 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar
docs: add comments describing newly added functions
ad8bdf0 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar
refactor: replace internals of BuildTestPod with NewTestPod
62c3506 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar
refactor: replace BuildTestPod with NewTestPod in eligibility tests
6e297d4 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar
feat: abstract baseNode out of BuildTestNode fn
842e604 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar
feat: wip divide pod and node related helpers into two separate packages
14280ce 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2023
@vadasambar
feat: wip use pod and node package instead of . importing test …
cc7e86e 
…utils

Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/provider/gce needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 27, 2023
@vadasambar
test: wip update code to use new node and pod package
bfe3e11 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar
feat: use test utils pod and node imports
5875531 
Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar vadasambar mentioned this pull request Aug 1, 2023
Closed
@vadasambar
feat: finish replacing test utils with pod and node test utils im…
c247f3f 
…ports

Signed-off-by: vadasambar <surajrbanakar@gmail.com>
@vadasambar
Copy link
Member Author

This PR has become too big. Might be a good idea to split it into 3 PRs:

  1. pod utils PR (deprecate existing pod functions in test utils pkg)
  2. node utils PR (deprecate existing node functions in test utils pkg)
  3. PR to use new pod and node utils across the codebase

@vadasambar vadasambar mentioned this pull request Aug 2, 2023
Closed
@vadasambar
Copy link
Member Author

Created #6008 for pod utils

@vadasambar vadasambar mentioned this pull request Sep 1, 2023
Closed
@vadasambar vadasambar mentioned this pull request Oct 3, 2023
Closed
@vadasambar vadasambar mentioned this pull request Nov 1, 2023
Closed
@vadasambar vadasambar mentioned this pull request Dec 4, 2023
Closed
@vadasambar vadasambar mentioned this pull request Jan 2, 2024
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024
@vadasambar
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2024
@vadasambar vadasambar mentioned this pull request Feb 2, 2024
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees
No one assigned
Labels
area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vadasambar @k8s-ci-robot @k8s-triage-robot