Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Scale down rule in the documentation (FAQ.md) #6290

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Clarify Scale down rule in the documentation (FAQ.md) #6290

merged 1 commit into from
Jan 8, 2024

Conversation

faan11
Copy link
Contributor

@faan11 faan11 commented Nov 15, 2023

Specify the maximum value in the CA scale-down rule

What type of PR is this?

/kind documentation

What this PR does / why we need it:

To clarify which criteria is currently used to scale down a node.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 15, 2023
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 15, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: faan11 / name: Fabio Pagnotta (6ec7256)

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @faan11!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2023
@Shubham82
Copy link
Contributor

you have to sign the CLA before the PR can be reviewed.
See the following document to sign the CLA: Signing Contributor License Agreements(CLA)

@Shubham82
Copy link
Contributor

To check EasyCLA

/easycla

@vadasambar
Copy link
Member

/assign vadasambar

vadasambar
vadasambar suggested changes Nov 21, 2023
View reviewed changes
cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
@vadasambar
Copy link
Member

@faan11 thank you for the PR! Mostly LGTM except the nits and can you sign the CLA please 🙏

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 30, 2023
@faan11
Copy link
Contributor Author

faan11 commented Nov 30, 2023

/easycla

@faan11
Copy link
Contributor Author

faan11 commented Nov 30, 2023

Hi vadasamba, sorry for the delay, i've accepted the Easycla license.
Thank you for your suggested changes. I suppose, we only need to merge this pull request.

@vadasambar
Copy link
Member

@faan11 can you address the review comments? Thanks.

@faan11
Copy link
Contributor Author

faan11 commented Nov 30, 2023

Yes, I've committed them. Now it should be clearer.

@Shubham82
Copy link
Contributor

@faan11, thanks for the changes, but you didn't update the help text for --scale-down-utilization-threshold as suggested by @vadasambar.

@faan11
Copy link
Contributor Author

faan11 commented Dec 2, 2023

Thank you @Shubham82, I apologize for misreading. I only read the first change. As suggested by @vadasambar , i provided a proper description for the flag scale-down-utilization-threshold . Let me know if it fine or we need to rephrase it somehow.

vadasambar
vadasambar suggested changes Dec 4, 2023
View reviewed changes
cluster-autoscaler/main.go Outdated Show resolved Hide resolved
@vadasambar
Copy link
Member

@faan11 almost there. Let me know when you are done with them.

@vadasambar vadasambar mentioned this pull request Dec 4, 2023
Closed
@faan11
Copy link
Contributor Author

faan11 commented Dec 5, 2023

Hi @vadasambar, thank you for your tips. I updated the file as you suggested, In the FAQ.md, i have also specified that the value is a floating point value that can range between 0 and 1.

Let me know if it is ok or you have additional pointers to improve this pull request.
Thank you

@Shubham82
Copy link
Contributor

@faan11, squash your commits.

@vadasambar
Copy link
Member

@faan11 can you squash your commits? Thank you! Otherwise LGTM

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 11, 2023
@faan11
Copy link
Contributor Author

faan11 commented Dec 11, 2023

Yes i'll squash the branch commits and notify you when i'm done with it.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
@faan11
Copy link
Contributor Author

faan11 commented Dec 11, 2023

I suppose we can proceed now @vadasambar @Shubham82

@Shubham82
Copy link
Contributor

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@vadasambar
Copy link
Member

Thank you for the PR @faan11 !

@BigDarkClown @x13n can we get approval on this 🙏

@faan11
Copy link
Contributor Author

faan11 commented Dec 31, 2023

HI @BigDarkClown @x13n,

Can you please review this issue?

Thank you

@vadasambar
Copy link
Member

HI @BigDarkClown @x13n,

Can you please review this issue?

Thank you

I will bring this PR up in the upcoming sig meeting on Monday (8th Jan) if you don't get an approval by then.

x13n
x13n reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@x13n x13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, feel free to cancel the hold if you disagree.

/lgtm
/approve
/hold

cluster-autoscaler/FAQ.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: faan11, vadasambar, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@faan11
docs: clarifies scale down operation by CA in FAQ.md and main.go
6ec7256 
This commit clarifies the condition when a node can be scaled down by the Cluster Autoscaler (CA).
The changes updates the section and flag description in the FAQ.md and main.go files.
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0024f25 into kubernetes:master Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x13n x13n x13n left review comments

@Shubham82 Shubham82 Shubham82 left review comments

@vadasambar vadasambar vadasambar approved these changes

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

Assignees

@x13n x13n

@vadasambar vadasambar

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faan11 @k8s-ci-robot @Shubham82 @vadasambar @x13n