Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpa - fix checkpoint gc of unknown recommenders #6767

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

vpa - fix checkpoint gc of unknown recommenders #6767

wants to merge 3 commits into from
+106 −2

Conversation

BojanZelic
Copy link

@BojanZelic BojanZelic commented Apr 24, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes the unintentional deletion of VPA checkpoints if using multiple recommenders

Which issue(s) this PR fixes:

Fixes #6387

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 24, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @BojanZelic!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @BojanZelic. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from kgolab and krzysied April 24, 2024 23:57
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 24, 2024
@adrianmoisey
Copy link
Member

(I'm not an owner of this code and my review is meaningless)
This code seems fine to me. It seems worth getting tests running and getting eyes from someone with actual review powers to look at it

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2024
@kam1kaze
Copy link

kam1kaze commented Sep 6, 2024

What do we need to merge this PR?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BojanZelic, heybronson, XiangningLi
Once this PR has been reviewed and has the lgtm label, please assign kgolab for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrianmoisey
Copy link
Member

Hey! Are you still willing to work on this PR?
I'd like to get this bug fixed

adrianmoisey
adrianmoisey reviewed Dec 20, 2024
View reviewed changes
vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go Outdated

allVpaResources, err := feeder.vpaLister.List(labels.Everything())
if err != nil {
klog.Errorf("Cannot list VPAs. Reason: %+v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be changed to structured logging?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianmoisey fixed

@adrianmoisey adrianmoisey mentioned this pull request Dec 20, 2024
Open
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmoisey adrianmoisey adrianmoisey left review comments

@XiangningLi XiangningLi XiangningLi approved these changes

@heybronson heybronson heybronson approved these changes

@kgolab kgolab Awaiting requested review from kgolab

@krzysied krzysied Awaiting requested review from krzysied

Assignees
No one assigned
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running Multiple Recommenders with Checkpointing results in deletion of checkpoints from other recommenders
6 participants
@BojanZelic @k8s-ci-robot @adrianmoisey @kam1kaze @heybronson @XiangningLi