-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vms pool implementation in 1.27 #7292
base: cluster-autoscaler-release-1.27
Are you sure you want to change the base?
Add vms pool implementation in 1.27 #7292
Conversation
Hi @wenxuan0923. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wenxuan0923 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good, left some comments
@@ -89,6 +89,9 @@ type Config struct { | |||
// EnableForceDelete defines whether to enable force deletion on the APIs | |||
EnableForceDelete bool `json:"enableForceDelete,omitempty" yaml:"enableForceDelete,omitempty"` | |||
|
|||
// EnableVMsAgentPool defines whether to support VMs agentpool type in addition to VMSS type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend adding some notes here regarding the current nature of this feature (e.g., for testing only, not production ready)
Taints []string | ||
// for vmss pool only | ||
InputLabels map[string]string | ||
InputTaints string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the difference between this and Taints
just the data type and usage?
Wondering if there is a way to make that more intuitive, maybe adding a comment?
/ok-to-test |
a2b1b3f
to
3029147
Compare
What type of PR is this?
/kind feature
Optionally add one or more of the following kinds if applicable:
-->
What this PR does / why we need it:
Add implementation to support VMs pool autoscaling. It does not support GPU pool for now (will be handled later).
It is same with #6951, but for version 1.27
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
EnableVMsAgentPool
to guard the behavior for VMs pool - it is default tofalse
(azure_config.go
)azure_cache.go
)NodeTemplate
which supports both VMSS and VMs agentpool, it will be used for scaling up VMs pool with 0 node. Before this change, only VMSS instance can be used as node template. (azure_template.go
)azure_vms_pool.go
)Does this PR introduce a user-facing change?
NONE (change is guarded by a toggle
enableVMsAgentPool
which is default to false. No cx-facing change right now.)Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: