Document that client-go is not yet compatible with dep #319
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/M
|
cc @rickypai @danderson |
INSTALL.md
Outdated
| However, client-go does not work well with `dep` yet. To support `dep`, we need | ||
| to fix at least two issues: | ||
| 1. publish native `Gopkg.toml` in client-go and other k8s.io repos, like `k8s.io/apimachinery`; | ||
| 2. find a way to express transitive constraints (see https://github.com/golang/dep/issues/1124). |
There was a problem hiding this comment.
Looks good. I would add: If you use dep today, you have to specify client-go dependencies manually in Gopkg.toml.
The client-go vendoring reality looks like this: https://twitter.com/the_sttts/status/924931147003547648. So many people use dep (more or less successfully, more or less due to luck that the master branches of our dependencies happen to work with our code today).
caesarxuchao
force-pushed
the
remove-dep
branch
2 times, most recently
from
0ac5ae2 to
95f098b
Compare
INSTALL.md
Outdated
|
|
||
| To use `dep` with client-go safely today, you have to specify client-go | ||
| dependencies manually in Gopkg.toml with the versions listed in | ||
| [Godeps.json](./Godeps/Godeps.json). |
There was a problem hiding this comment.
We should probably repeat that this is not yet supported. We should also set expectations as to the cost of migrating from the work around to the final solution.
caesarxuchao
force-pushed
the
remove-dep
branch
from
95f098b to
163dce1
Compare
caesarxuchao
force-pushed
the
remove-dep
branch
from
163dce1 to
62be166
Compare
|
|
||
| As a workaround, which may or may not be worthwhile, you can specify all | ||
| client-go dependencies manually as | ||
| [override](https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md#override) |
There was a problem hiding this comment.
@sttts is this accurate?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thank you both for the review. |
@sttts could you proof read this? Thank you.