Skip to content

Commit

Permalink
Merge pull request #743 from syseleven/openstack_dont_delete_lb_on_er…
Browse files Browse the repository at this point in the history
…rors

Do not Delete LB in Case of Security Group Reconciliation Errors
  • Loading branch information
adisky authored Sep 6, 2019
2 parents 39d1b82 + f365c4e commit a452516
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1336,9 +1336,7 @@ func (lbaas *LbaasV2) EnsureLoadBalancer(ctx context.Context, clusterName string
if lbaas.opts.ManageSecurityGroups {
err := lbaas.ensureSecurityGroup(clusterName, apiService, nodes, loadbalancer)
if err != nil {
// cleanup what was created so far
_ = lbaas.EnsureLoadBalancerDeleted(ctx, clusterName, apiService)
return status, err
return status, fmt.Errorf("Error reconciling security groups for LB service %v/%v: %v", apiService.Namespace, apiService.Name, err)
}
}

Expand Down

0 comments on commit a452516

Please sign in to comment.