do not delete LB in case on security group reconciliation errors

kubernetes · Sep 3, 2019 · afd44da · afd44da
1 parent 8f386af
commit afd44da
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go b/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go
@@ -1336,9 +1336,7 @@ func (lbaas *LbaasV2) EnsureLoadBalancer(ctx context.Context, clusterName string
 	if lbaas.opts.ManageSecurityGroups {
 		err := lbaas.ensureSecurityGroup(clusterName, apiService, nodes, loadbalancer)
 		if err != nil {
-			// cleanup what was created so far
-			_ = lbaas.EnsureLoadBalancerDeleted(ctx, clusterName, apiService)
-			return status, err
+			return status, fmt.Errorf("Error reconciling LB SGs for LB service %v/%v: %v", apiService.Namespace, apiService.Name, err)
 		}
 	}