Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manila-csi-plugin] Fix error connecting to nfs plugin when using cluster proxy #1528

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented May 11, 2021

Which issue this PR fixes(if applicable):
fixes #1527

Special notes for reviewers:
This is very simple to reproduce on OpenShift by setting a cluster-wide proxy. See #1527 for reproducer steps.

Release note:

NONE

NOTE

A better fix would be to update gRPC to at least v1.34.0 which contains grpc/grpc-go#3890. This supports the unix protocol explicitly and never proxies it. However, due to our transitive dep on etcd clientv3 and etcd-io/etcd#11563 we are pinned to gRPC <= v1.30.0. The etcd 3.5 branch has finally bumped the gRPC version, but that is not released yet. None of the etcd stable branch tags contain a gRPC bump.

/cc @Fedosin

@k8s-ci-robot k8s-ci-robot requested a review from Fedosin May 11, 2021 13:26
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @mdbooth. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2021
@Fedosin
Copy link
Contributor

Fedosin commented May 11, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build succeeded.

@tombarron
Copy link
Contributor

@gman0 ptal

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build succeeded.

@k8s-ci-robot
Copy link
Contributor

@Fedosin: Fedosin unauthorized: /override is restricted to Repo administrators.

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build succeeded.

@mdbooth
Copy link
Contributor Author

mdbooth commented May 11, 2021

/retest

@gman0
Copy link
Member

gman0 commented May 11, 2021

Thanks, @mdbooth !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021
@gman0
Copy link
Member

gman0 commented May 11, 2021

Let's see about the CI.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2021

Build succeeded.

Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mdbooth
Copy link
Contributor Author

mdbooth commented May 18, 2021

/test cloud-provider-openstack-acceptance-test-e2e-conformance
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

@k8s-ci-robot
Copy link
Contributor

@mdbooth: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-e2e-conformance
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18
/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-e2e-conformance

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 24, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 24, 2021

Build succeeded.

@ramineni
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

@k8s-ci-robot
Copy link
Contributor

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Contributor

lb-octaia job is disabled now.
/override openlab/cloud-provider-openstack-acceptance-test-lb-octavia

@k8s-ci-robot
Copy link
Contributor

@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-acceptance-test-lb-octavia

In response to this:

lb-octaia job is disabled now.
/override openlab/cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 25, 2021

Build succeeded.

@Fedosin
Copy link
Contributor

Fedosin commented May 31, 2021

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

@k8s-ci-robot
Copy link
Contributor

@Fedosin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Contributor

Fedosin commented May 31, 2021

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

@k8s-ci-robot
Copy link
Contributor

@Fedosin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@tombarron tombarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we can get this in.

@tombarron
Copy link
Contributor

@ramineni Can you help us get this one in? We've got a downstream customer who needs it. Thanks!

@ramineni
Copy link
Contributor

ramineni commented Jun 1, 2021

overriding 1.18-e2e-conformance , as no need for this PR and also would be removed in future on master branch
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

@k8s-ci-robot
Copy link
Contributor

@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

In response to this:

overriding 1.18-e2e-conformance , as no need for this PR and also would be removed in future on master branch
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Contributor

ramineni commented Jun 1, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7f956c2 into kubernetes:master Jun 1, 2021
@tombarron
Copy link
Contributor

@ramineni Thanks much!

powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
…ster proxy (kubernetes#1528)

* Bump gRPC to v1.29.0 (kubernetes#1527)

This bump is required to add support for grpc.WithNoProxy().

Note that bumping to v1.30.0 or newer causes a build failure in
go.etcd.io/etcd/clientv3, described in
etcd-io/etcd#11563. It is not possible to bump
gRPC further until etcd v3.5 is released, which updates the relevant api
uses.

* [manila-csi-plugin] Ignore proxy connecting to CSI sockets (kubernetes#1527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[manila-csi-plugin] Cannot connect to csi-nfsplugin if the cluster uses a proxy
6 participants