Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCCM] Add --cluster-name=$(CLUSTER_NAME) support #1809

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Mar 9, 2022

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1807

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2022
@jichenjc
Copy link
Contributor Author

jichenjc commented Mar 9, 2022

/retest-required

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-controller-manager-e2e-conformance-test 2875856 link true /test openstack-cloud-controller-manager-e2e-conformance-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

- name: CLUSTER_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think using nodeName is a good idea, maybe just set a default value kubernetes?

@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2022
@ramineni
Copy link
Contributor

Thanks.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 93f74e5 into kubernetes:master Mar 15, 2022
@powellchristoph
Copy link
Contributor

Could we get a new Chart version? I've run into this exact problem.

@jichenjc
Copy link
Contributor Author

@lingxiankong @ramineni does this need a bump of OCCM version (e.g 1.23=>1.23.1 )
or a separate flow of release a new chart? I didn't do it personally before and I can do it if any doc we have

@lingxiankong
Copy link
Contributor

As we are still in the dev cycle, it's not possible to do a chart release given the code is not officially released, and this change is kind of "new feature", so it doesn't fit into the backport policy neither. We have to wait until the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[occm][lb] Incorrect cluster name
5 participants