-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCCM] Add --cluster-name=$(CLUSTER_NAME) support #1809
Conversation
/retest-required |
@jichenjc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- name: CLUSTER_NAME | ||
valueFrom: | ||
fieldRef: | ||
fieldPath: spec.nodeName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think using nodeName is a good idea, maybe just set a default value kubernetes
?
/lgtm |
Thanks. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ramineni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Could we get a new Chart version? I've run into this exact problem. |
@lingxiankong @ramineni does this need a bump of OCCM version (e.g 1.23=>1.23.1 ) |
As we are still in the dev cycle, it's not possible to do a chart release given the code is not officially released, and this change is kind of "new feature", so it doesn't fit into the backport policy neither. We have to wait until the next release. |
What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #1807
Special notes for reviewers:
Release note: