-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always ensure KIND is present for integration test #274
Conversation
This patch adds a step in the integration test Makefile to explicitly install KIND if it is not present. The default KIND version is now v0.5.1, which requires changes to the kind config to use the v1alpha3 API. Part of the movitivation behind this is to be able to run the integration test in the kubekins-e2e image rather than a custom "CI" image created from this project.
/lgtm Just waiting on kubernetes/test-infra#15171 to get merged |
Cool -- with the test-infra stuff merged, I can run tests manually now... |
@codenrhoden: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold cancel Woohoo! Integration test passes. Only test failure here is the unit test, and I think that's the issue @dvonthenen is trying to fix in #273. Since it's not a required test here, we should be good to go. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dvonthenen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
appears to be no way I can skip the failed test, even though it is not required. Once I add it, seems to be no way to remove it. Going to close and reopen just to see what happens. /close |
@codenrhoden: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@codenrhoden: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This (in conjunction with a test-infra PR) will fix the failing integration tests.
This patch adds a step in the integration test Makefile to explicitly
install KIND if it is not present. The default KIND version is now
v0.5.1, which requires changes to the kind config to use the v1alpha3
API.
Part of the movitivation behind this is to be able to run the
integration test in the kubekins-e2e image rather than a custom "CI"
image created from this project.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note:
/hold
^ until kubernetes/test-infra#15171 is merged
/assign @dvonthenen