Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always ensure KIND is present for integration test #274

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

codenrhoden
Copy link
Contributor

What this PR does / why we need it:
This (in conjunction with a test-infra PR) will fix the failing integration tests.

This patch adds a step in the integration test Makefile to explicitly
install KIND if it is not present. The default KIND version is now
v0.5.1, which requires changes to the kind config to use the v1alpha3
API.

Part of the movitivation behind this is to be able to run the
integration test in the kubekins-e2e image rather than a custom "CI"
image created from this project.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

/hold
^ until kubernetes/test-infra#15171 is merged

/assign @dvonthenen

This patch adds a step in the integration test Makefile to explicitly
install KIND if it is not present. The default KIND version is now
v0.5.1, which requires changes to the kind config to use the v1alpha3
API.

Part of the movitivation behind this is to be able to run the
integration test in the kubekins-e2e image rather than a custom "CI"
image created from this project.
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2019
@dvonthenen
Copy link
Contributor

/lgtm

Just waiting on kubernetes/test-infra#15171 to get merged

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019
@codenrhoden
Copy link
Contributor Author

Cool -- with the test-infra stuff merged, I can run tests manually now...
/test pull-cloud-provider-vsphere-build
/test pull-cloud-provider-vsphere-unit-test
/test pull-cloud-provider-vsphere-integration-test

@k8s-ci-robot
Copy link
Contributor

@codenrhoden: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cloud-provider-vsphere-unit-test dd3f3ab link /test pull-cloud-provider-vsphere-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codenrhoden
Copy link
Contributor Author

/hold cancel

Woohoo! Integration test passes. Only test failure here is the unit test, and I think that's the issue @dvonthenen is trying to fix in #273. Since it's not a required test here, we should be good to go.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2019
@dvonthenen
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dvonthenen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@codenrhoden
Copy link
Contributor Author

appears to be no way I can skip the failed test, even though it is not required. Once I add it, seems to be no way to remove it. Going to close and reopen just to see what happens.

/close

@k8s-ci-robot
Copy link
Contributor

@codenrhoden: Closed this PR.

In response to this:

appears to be no way I can skip the failed test, even though it is not required. Once I add it, seems to be no way to remove it. Going to close and reopen just to see what happens.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codenrhoden
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

@codenrhoden: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dvonthenen dvonthenen merged commit 9753b10 into kubernetes:master Nov 7, 2019
@codenrhoden codenrhoden deleted the kubekins-integration branch November 7, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants