Skip to content

Commit

Permalink
Merge pull request #2918 from deads2k/godep-update
Browse files Browse the repository at this point in the history
add acceptable justifications for updating a godep
  • Loading branch information
k8s-ci-robot authored Nov 9, 2018
2 parents 6fb5d42 + c18b458 commit 13964e8
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions contributors/devel/godep.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@ the tools.

This doc will focus on predictability and reproducibility.

## Justifications for an update

Before you update a dependency, take a moment to consider why it should be
updated. Valid reasons include:
1. We need new functionality that is in a later version.
2. New or improved APIs in the dependency significantly improve Kubernetes code.
3. Bugs were fixed that impact Kubernetes.
4. Security issues were fixed even if they don't impact Kubernetes yet.
5. Performance, scale, or efficiency was meaningfully improved.
6. We need dependency A and there is a transitive dependency B.
7. Kubernetes has an older level of a dependency that is precluding being able
to work with other projects in the ecosystem.

## Theory of operation

The `go` toolchain assumes a global workspace that hosts all of your Go code.
Expand Down

0 comments on commit 13964e8

Please sign in to comment.