Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create repository named cli-runtime and sample-cli-plugin under kubernetes github org #2626

Closed
dims opened this issue Sep 4, 2018 · 11 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@dims
Copy link
Member

dims commented Sep 4, 2018

In kubernetes/kubernetes#67658, we added staging/src/k8s.io/cli-runtime/* in the main k/k repository, we don't yet have

Same deal for kubernetes/kubernetes#67938 that added staging/src/k8s.io/sample-cli-plugin/*

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 4, 2018
@dims
Copy link
Member Author

dims commented Sep 4, 2018

Request from @pohly on slack

pohly [12:18 PM]
Where is the git repo for the "k8s.io/cli-runtime" package? I'm running into a problem where "dep" fails to find the source code for that package. This can be reproduce with "go get k8s.io/cli-runtime/pkg/genericclioptions": it tries to check out https://github.com/kubernetes/cli-runtime, but that repo does not exit.

I know that the original source code is in kubernetes/kubernetes, but shouldn't it get mirrored?
For example, k8s.io/apiserver is mirrored at https://github.com/kubernetes/apiserver.
kubernetes/apiserver
Library for writing a Kubernetes-style API server.
Stars
112
Language
Go
kubernetes/apiserverJan 13th, 2017Added by GitHub
Oh, it's brand-new (created August 21st), so it probably simply hasn't been mirrored yet.

@dims
Copy link
Member Author

dims commented Sep 4, 2018

/sig cli
/sig architecture

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2018
@spiffxp
Copy link
Member

spiffxp commented Sep 4, 2018

/sig cli
/sig architecture
We need sign off from the above sigs (pinging @kubernetes/sig-cli-feature-requests and @kubernetes/sig-architecture-feature-requests)

You may want to contact them on other channels as well and send them to this request.

Per the requirements: https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md#core-repositories

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 4, 2018
@dims
Copy link
Member Author

dims commented Sep 4, 2018

@soltysh @pwittrock @adohe - can you please approve on behalf of the @kubernetes/sig-cli-maintainers ?

@dims dims changed the title Please create repository named cli-runtime under kubernetes github org Please create repository named cli-runtime and sample-cli-plugin under kubernetes github org Sep 4, 2018
@jdumars
Copy link
Member

jdumars commented Sep 4, 2018

We don't have a formal decision-making system established in SIG-Architecture, so my feeling is to bring this and #2627 to our next meeting.

@sttts
Copy link
Contributor

sttts commented Sep 4, 2018

/xref kubernetes/org#58

Same topic.

@sttts
Copy link
Contributor

sttts commented Sep 4, 2018

@dims please compare the required permission documented in kubernetes/org#58

@spiffxp
Copy link
Member

spiffxp commented Sep 4, 2018

Same as #2627 (comment) we'll need these requests opened in k/org, but happy to use this issue as a place to link to for the decisions/approvals

@bgrant0607
Copy link
Member

SIG Arch signed off on this via email.

@soltysh
Copy link
Contributor

soltysh commented Sep 7, 2018

I think this can be close now.
/close

@k8s-ci-robot
Copy link
Contributor

@soltysh: Closing this issue.

In response to this:

I think this can be close now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Development

No branches or pull requests

7 participants