Update docs for cri-tools #2191
Conversation
k8s-ci-robot
added
size/L
|
/cc @yujuhong @Random-Liu |
k8s-ci-robot
requested review from
calebamiles,
grodrigues3,
Random-Liu and
yujuhong
and removed request for
calebamiles and
grodrigues3
|
cc @kubernetes/sig-node-pr-reviews |
k8s-ci-robot
added
the
sig/node
k8s-ci-robot
added
size/M
|
/assign @Random-Liu @yujuhong |
contributors/devel/cri-validation.md
Outdated
|
|
||
| - By setting flags `--runtime-endpoint` and `--image-endpoint` | ||
| - By setting environment variables `CRI_RUNTIME_ENDPOINT` and `CRI_IMAGE_ENDPOINT` | ||
| critest connects to `unit:///var/run/dockershim.sock` by default. For other runtimes, the endpoint can be set by flags `-runtime-endpoint` and `-image-endpoint`. |
There was a problem hiding this comment.
s/unit/unix
Is it -runtime-endpoint or --runtime-endpoint?
There was a problem hiding this comment.
ACK, those options are Go flags, so -runtime-endpoint is right. Also additional flags are in same format.
| critest connects to `/var/run/dockershim.sock` by default. For other runtimes, the endpoint can be set in two ways: | ||
|
|
||
| - By setting flags `--runtime-endpoint` and `--image-endpoint` | ||
| - By setting environment variables `CRI_RUNTIME_ENDPOINT` and `CRI_IMAGE_ENDPOINT` |
There was a problem hiding this comment.
Were the environment variables removed, and why?
There was a problem hiding this comment.
Yep, those environment variables are introduced with lib github.com/urfave/cli. But with this lib, critest requires Go installed whenever running validation tests. So we moved to go test -c for building critest binary and it doesn't require Go for running critest.
|
@yujuhong Addressed comments. PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@cblecker Could you help to approve the PR? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Documentation for kubernetes/enhancements#292.