Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mrbobbytables to github admins team #3787

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Add mrbobbytables to github admins team #3787

merged 1 commit into from
Jun 12, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jun 10, 2019

kubernetes-sig-contribex@
thread
for the nomination

calebamiles has graciously agreed to step down to make room for
mrbobbytables on the github admin team

/hold
/committee steering
need majority of steering committee to lgtm this change
/assign @mrbobbytables
can you confirm you're interested in this, and accept the security
embargo policy?

This may prompt the question of Bob's role as a New Membership
Coordinator, I would like for Bob to handle that separately once this
nomination has been addressed.

There will be a corresponding kubernetes/org to implement these changes
shortly

@spiffxp
Add mrbobbytables to github admins team
032df08 
calebamiles has graciously agreed to step down to make room
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. committee/steering Denotes an issue or PR intended to be handled by the steering committee. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jun 10, 2019

steering@ thread

@dims
Copy link
Member

dims commented Jun 10, 2019

+1 (binding/steering)

@mrbobbytables
Copy link
Member

can you confirm you're interested in this, and accept the security
embargo policy?

Confirmed. I would be more than happy to join the admin team and accept the security embargo policy.👍

This may prompt the question of Bob's role as a New Membership
Coordinator, I would like for Bob to handle that separately once this
nomination has been addressed.

I've been thinking about this one and have a candidate in mind :)

idvoretskyi
idvoretskyi approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2019
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, idvoretskyi, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp spiffxp mentioned this pull request Jun 10, 2019
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Jun 10, 2019

PR implementing the change in kubernetes/org: kubernetes/org#900

@michelleN
Copy link

/lgtm

@timothysc
Copy link
Member

/lgtm

@derekwaynecarr
Copy link
Member

/lgtm

@smarterclayton
Copy link
Contributor

/lgtm

@pwittrock
Copy link
Member

/lgtm

@spiffxp
Copy link
Member Author

spiffxp commented Jun 12, 2019

/hold cancel
7/12 steering members is simple majority, thanks all

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7af65cc into kubernetes:master Jun 12, 2019
@spiffxp spiffxp deleted the add-mrbobbytables-to-github-admins branch June 12, 2019 20:46
@bgrant0607
Copy link
Member

Sorry, late but lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@idvoretskyi idvoretskyi

@timothysc timothysc

@smarterclayton smarterclayton

@cblecker cblecker

@michelleN michelleN

@derekwaynecarr derekwaynecarr

@mrbobbytables mrbobbytables

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.