-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Federation] Federated hpa design #593
[Federation] Federated hpa design #593
Conversation
@irfanurrehman Please clearly label the original Google Doc as deprecated, with a link to this PR as the new place to discuss the design. Otherwise people who land at that document will be unaware of the conversation here. Thanks. Q |
@quinton-hoole, Done! |
/lgtm |
95bebd3
to
6eed714
Compare
Automatic merge from submit-queue (batch tested with PRs 45993, 50293) [Federation] HPA controller This PR implements the design listed in kubernetes/community#593. This is still a work in progress, and needs more unit tests to be added. I will add the integration tests and e2e tests in a separate PR(s). @kubernetes/sig-federation-pr-reviews **Release note**: ``` Horizontal Pod Autoscaling is now available as an alpha feature in federation. It can be used to distribute and scale workload across clusters joined in a federation. In its current form, it works only on cpu utilization and the support for other metrics is yet to be built in. ```
@quinton-hoole |
/lgtm cancel //PR changed after LGTM, removing LGTM. @DirectXMan12 @irfanurrehman @mwielgus @quinton-hoole |
Automatic merge from submit-queue (batch tested with PRs 45993, 50293) [Federation] HPA controller This PR implements the design listed in kubernetes/community#593. This is still a work in progress, and needs more unit tests to be added. I will add the integration tests and e2e tests in a separate PR(s). @kubernetes/sig-federation-pr-reviews **Release note**: ``` Horizontal Pod Autoscaling is now available as an alpha feature in federation. It can be used to distribute and scale workload across clusters joined in a federation. In its current form, it works only on cpu utilization and the support for other metrics is yet to be built in. ```
This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review. cc @DirectXMan12 @irfanurrehman @mwielgus @quinton-hoole You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days |
This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review. cc @DirectXMan12 @irfanurrehman @mwielgus @quinton-hoole You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days |
@quinton-hoole, given the feature is implemented and merged too, can we please lgtm and merge this. |
👍 |
Wow, sorry for the long delay. I wonder whether this belongs in kubernetes/federation, now that we have that new repo? |
6eed714
to
336f7d3
Compare
Thanks for checking this, I too did forget about this. |
Also update a spelling suggestion by newly implemented hack/verify-spelling.sh
336f7d3
to
16503b7
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irfanurrehman, quinton-hoole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For reference, there already has been quite a lot of discussion over this design here.
A very readable version of this doc can be viewed on my fork here
@kubernetes/sig-federation-feature-requests
@kubernetes/sig-federation-misc
@kubernetes/sig-autoscaling-feature-requests