Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Federation] Federated hpa design #593

Merged
merged 3 commits into from
Mar 13, 2018

Conversation

irfanurrehman
Copy link
Contributor

@irfanurrehman irfanurrehman commented May 2, 2017

For reference, there already has been quite a lot of discussion over this design here.

A very readable version of this doc can be viewed on my fork here

@kubernetes/sig-federation-feature-requests
@kubernetes/sig-federation-misc
@kubernetes/sig-autoscaling-feature-requests

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2017
@irfanurrehman irfanurrehman requested a review from marun May 2, 2017 09:23
@irfanurrehman irfanurrehman self-assigned this May 2, 2017
@irfanurrehman irfanurrehman requested review from a user and mwielgus May 2, 2017 17:41
@ghost
Copy link

ghost commented May 2, 2017

@irfanurrehman Please clearly label the original Google Doc as deprecated, with a link to this PR as the new place to discuss the design. Otherwise people who land at that document will be unaware of the conversation here. Thanks. Q

@irfanurrehman
Copy link
Contributor Author

@quinton-hoole, Done!

@ghost
Copy link

ghost commented Jul 5, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot assigned ghost Jul 5, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2017
@irfanurrehman irfanurrehman force-pushed the federated-hpa-design branch from 95bebd3 to 6eed714 Compare July 10, 2017 14:01
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Aug 8, 2017
Automatic merge from submit-queue (batch tested with PRs 45993, 50293)

[Federation] HPA controller

This PR implements the design listed in kubernetes/community#593.
This is still a work in progress, and needs more unit tests to be added.
I will add the integration tests and e2e tests in a separate PR(s).

@kubernetes/sig-federation-pr-reviews 

**Release note**:

```
Horizontal Pod Autoscaling is now available as an alpha feature in federation. 
It can be used to distribute and scale workload across clusters joined in a federation. 
In its current form, it works only on cpu utilization and the support for other metrics is yet to be built in.
```
@irfanurrehman
Copy link
Contributor Author

@quinton-hoole
@kubernetes/sig-federation-feature-requests
does this seem worthy to be merged, now?

@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 15, 2017
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2017
@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @DirectXMan12 @irfanurrehman @mwielgus @quinton-hoole

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2017
perotinus pushed a commit to kubernetes-retired/cluster-registry that referenced this pull request Sep 2, 2017
Automatic merge from submit-queue (batch tested with PRs 45993, 50293)

[Federation] HPA controller

This PR implements the design listed in kubernetes/community#593.
This is still a work in progress, and needs more unit tests to be added.
I will add the integration tests and e2e tests in a separate PR(s).

@kubernetes/sig-federation-pr-reviews 

**Release note**:

```
Horizontal Pod Autoscaling is now available as an alpha feature in federation. 
It can be used to distribute and scale workload across clusters joined in a federation. 
In its current form, it works only on cpu utilization and the support for other metrics is yet to be built in.
```
@k8s-github-robot
Copy link

This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review.

cc @DirectXMan12 @irfanurrehman @mwielgus @quinton-hoole

You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days

@k8s-github-robot
Copy link

This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review.

cc @DirectXMan12 @irfanurrehman @mwielgus @quinton-hoole

You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days

@irfanurrehman irfanurrehman reopened this Nov 14, 2017
@irfanurrehman
Copy link
Contributor Author

@quinton-hoole, given the feature is implemented and merged too, can we please lgtm and merge this.

@warmchang
Copy link
Contributor

👍

@k8s-github-robot k8s-github-robot added the kind/design Categorizes issue or PR as related to design. label Feb 6, 2018
@ghost
Copy link

ghost commented Mar 12, 2018

Wow, sorry for the long delay. I wonder whether this belongs in kubernetes/federation, now that we have that new repo?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2018
@irfanurrehman
Copy link
Contributor Author

Wow, sorry for the long delay. I wonder whether this belongs in kubernetes/federation, now that we have that new repo?

Thanks for checking this, I too did forget about this.
sig-multicluster design proposals are now maintained here, which still remains in community repo. Updated this PR to place the proposal at the right location.

Also update a spelling suggestion by newly implemented hack/verify-spelling.sh
@ghost
Copy link

ghost commented Mar 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2018
@ghost
Copy link

ghost commented Mar 13, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irfanurrehman, quinton-hoole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 93e9ec6 into kubernetes:master Mar 13, 2018
danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants