Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix K8sContributors twitter handle link in K8s.dev website #257

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Fix K8sContributors twitter handle link in K8s.dev website #257

merged 3 commits into from
Nov 17, 2021

Conversation

sandipanpanda
Copy link
Member

Fixes #256

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @sandipanpanda!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2021
@sandipanpanda sandipanpanda mentioned this pull request Nov 11, 2021
Closed
7 tasks
@mrbobbytables
Copy link
Member

This is a markdown rendering issue with hugo, the link is there in reference form on line 92. I would opt to fix the rendering issue over breaking from the standard of using reference links.

@CIPHERTron
Copy link
Member

This is a markdown rendering issue with hugo, the link is there in reference form on line 92. I would opt to fix the rendering issue over breaking from the standard of using reference links.

Oh yeah, right. Didn't see that.

https://deploy-preview-257--kubernetes-contributor.netlify.app/resources/services/
Here's the preview for this PR. The issue is fixed.
Thanks, @sandipanpanda 🎉

@CIPHERTron
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@sandipanpanda
Copy link
Member Author

sandipanpanda commented Nov 17, 2021 •
edited
Loading

PTAL https://deploy-preview-257--kubernetes-contributor.netlify.app/resources/services/#contributor-communications

cc @mrbobbytables

mrbobbytables
mrbobbytables reviewed Nov 17, 2021
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, sandipanpanda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9936bdb into kubernetes:master Nov 17, 2021
@sandipanpanda sandipanpanda deleted the fix-issue-256 branch November 17, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables mrbobbytables left review comments

@CIPHERTron CIPHERTron CIPHERTron left review comments

@castrojo castrojo Awaiting requested review from castrojo

@idvoretskyi idvoretskyi Awaiting requested review from idvoretskyi

Assignees

@CIPHERTron CIPHERTron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link of K8sContributors Twitter handle in K8s.dev website
4 participants
@sandipanpanda @k8s-ci-robot @mrbobbytables @CIPHERTron