JS compiler fixes after new compiler release

kubernetes · Mar 29, 2016 · c0769af · c0769af
1 parent 185a7d0
commit c0769af
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/build/script.js b/build/script.js
@@ -88,8 +88,6 @@ gulp.task('scripts:prod', ['angular-templates'], function() {
       jscomp_error: '*',
       // Disable checks that are not applicable to the project.
       jscomp_off: [
-        // This check does not work correctly with ES6.
-        'inferredConstCheck',
         // Let ESLint handle all lint checks.
         'lintChecks',
         // This checks aren't working with current google-closure-library version. Will be deleted

diff --git a/src/app/frontend/common/components/labels/labels_controller.js b/src/app/frontend/common/components/labels/labels_controller.js
@@ -37,7 +37,7 @@ export default class LabelsController {
   /**
    * Returns true if element at index position should be visible.
    *
-   * @param index
+   * @param {number} index
    * @return {boolean}
    * @export
    */

diff --git a/src/app/frontend/common/components/sparkline/sparkline_controller.js b/src/app/frontend/common/components/sparkline/sparkline_controller.js
@@ -32,7 +32,7 @@ export default class SparklineController {
 
   /**
    * Formats the underlying series suitable for display as an SVG polygon.
-   * @return string
+   * @return {string}
    * @export
    */
   polygonPoints() {

diff --git a/src/app/frontend/logs/logs_state.js b/src/app/frontend/logs/logs_state.js
@@ -26,9 +26,9 @@ export class StateParams {
    * @param {string} namespace
    * @param {string} replicationController
    * @param {string} podId
-   * @param {string=} [container]
+   * @param {string=} opt_container
    */
-  constructor(namespace, replicationController, podId, container) {
+  constructor(namespace, replicationController, podId, opt_container) {
     /** @export {string} Namespace of this Replication Controller. */
     this.namespace = namespace;
 
@@ -39,6 +39,6 @@ export class StateParams {
     this.podId = podId;
 
     /** @export {string|undefined} Name of this pod container. */
-    this.container = container;
+    this.container = opt_container;
   }
 }
diff --git a/src/app/frontend/replicationcontrollerlist/zerostate/zerostate_state.js b/src/app/frontend/replicationcontrollerlist/zerostate/zerostate_state.js
@@ -24,7 +24,7 @@ export const stateName = `${replicationcontrollers}.zero`;
  */
 export class StateParams {
   /**
-   * @param containsOnlyKubeSystemRCs
+   * @param {boolean} containsOnlyKubeSystemRCs
    */
   constructor(containsOnlyKubeSystemRCs) {
     /** @type {boolean} whether there are only RCs in namespace "kube-system" */