Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent page exit on the create page when there are unsaved changes #3567

Closed
eloyekunle opened this issue Feb 13, 2019 · 15 comments · Fixed by #6566
Closed

Prevent page exit on the create page when there are unsaved changes #3567

eloyekunle opened this issue Feb 13, 2019 · 15 comments · Fixed by #6566
Assignees
@kushthedude @avinashupadhya99
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@eloyekunle
Copy link
Contributor

What would you like to be added

On the resource creation page, it will be good to have a prompt asking users to confirm page reloads or navigation if the user has entered some content that have not yet been uploaded.
The prompt should also be applied on the various resource editing sections in the dashboard.

Why is this needed

This will ensure users do not accidentally lose contents they have entered in the boxes.

Comments

A sample prompt:

image
@eloyekunle eloyekunle added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2019
@maciaszczykm
Copy link
Member

In case of reload it is fine, I am wondering if we need it for navigation.

cc @floreks

@eloyekunle
Copy link
Contributor Author

If we'll save the changes locally even when the user navigates, then we can skip it for navigation and only show it for reload.
Otherwise, the changes will be lost on navigation.

@DanielUche
Copy link

i would like to work on this issue

@eloyekunle
Copy link
Contributor Author

@DanielUche Great :)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 28, 2019
@eloyekunle
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 9, 2019
@maciaszczykm maciaszczykm added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jun 10, 2019
@eloyekunle eloyekunle mentioned this issue Sep 4, 2019
Closed
6 tasks
@eloyekunle
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@eloyekunle:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 9, 2019
@kushthedude
Copy link

/assign

@avinashupadhya99
Copy link
Contributor

I'm gonna give this a go since it has not been worked on in 2 years

/assign

@avinashupadhya99 avinashupadhya99 mentioned this issue Oct 23, 2021
Merged
@prnam
Copy link

prnam commented Dec 26, 2021

Fixed on #6566

/close

@k8s-ci-robot
Copy link
Contributor

@prnam: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

Fixed on #6566

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prnam
Copy link

prnam commented Dec 26, 2021

Hey @floreks,

This is fixed on #6566, kindly close.

@floreks
Copy link
Member

floreks commented Dec 26, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@floreks: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kushthedude kushthedude

@avinashupadhya99 avinashupadhya99

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent page exit on the create page when there are unsaved changes
9 participants
@floreks @maciaszczykm @eloyekunle @DanielUche @k8s-ci-robot @fejta-bot @kushthedude @avinashupadhya99 @prnam