Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate container image name on deploy page #422

Closed
bryk opened this issue Feb 24, 2016 · 6 comments
Closed

Validate container image name on deploy page #422

bryk opened this issue Feb 24, 2016 · 6 comments

Comments

@bryk
Copy link
Contributor

bryk commented Feb 24, 2016

Once #403 gets merged we should validate containter image name. It should be easy since @f-higashi researched how the image should look like.

@f-higashi Can you take this?

@bryk bryk added this to the v1.0 milestone Feb 24, 2016
@f-higashi
Copy link
Contributor

Yes.
I can take this.

@f-higashi
Copy link
Contributor

Docker has a difference format for reference between versions.
For example, v1.7 does not allow 'host:port/ns1/xxx/image:v1.
V1.10 allow it.

I think our validation allow newer version.
Is it OK?

cf.)
1.7
https://github.com/docker/docker/blob/v1.7.1/registry/config.go#L35-L36
In L213, reference is split in only two. So if reference has three /, repo has / and it does not matched validRepo.

1.10
https://github.com/docker/docker/blob/v1.10.2/reference/reference.go
https://github.com/docker/distribution/blob/docker/1.10/reference/reference.go#L6-L21

@bryk
Copy link
Contributor Author

bryk commented Mar 1, 2016

I think we should allow the less restrictive values. We don't know which version of Docker users have.

@f-higashi
Copy link
Contributor

I think so.
Newer docker version allows the less restrictive values.
I'll use this.

@codegoblins
Copy link

reposting from slack for visibility: I’d like to see more integrations with container registries, e.g. being able to search public images from within the deploy from settings flow. I worked on a similar feature for an internal kubernetes UI and would be happy to contribute.

@bryk
Copy link
Contributor Author

bryk commented Mar 4, 2016

@codegoblins Yeah, sure. We wanted to do this at some point, but didn't have time to. Please report a feature request first, though. And let's discuss it there.

@bryk bryk closed this as completed Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants