-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate container image name on deploy page #422
Comments
Yes. |
Docker has a difference format for reference between versions. I think our validation allow newer version. cf.) 1.10 |
I think we should allow the less restrictive values. We don't know which version of Docker users have. |
I think so. |
reposting from slack for visibility: I’d like to see more integrations with container registries, e.g. being able to search public images from within the deploy from settings flow. I worked on a similar feature for an internal kubernetes UI and would be happy to contribute. |
@codegoblins Yeah, sure. We wanted to do this at some point, but didn't have time to. Please report a feature request first, though. And let's discuss it there. |
Once #403 gets merged we should validate containter image name. It should be easy since @f-higashi researched how the image should look like.
@f-higashi Can you take this?
The text was updated successfully, but these errors were encountered: