Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container image validation #474

Closed

Conversation

f-higashi
Copy link
Contributor

Added container image validation. #422

Image reference format is very complicated. I think it is hard to write and maintain it.
So I used docker library in backend.

What do you think?

@bryk

BTW
How do I update Godep.json?
When I executed 'godep save ./src/app/backend', all dependencies are removed.

Review on Reviewable

@bryk
Copy link
Contributor

bryk commented Mar 2, 2016

@maciaszczykm You've recently updated Godeps. Can you help @f-higashi with this?

@maciaszczykm
Copy link
Member

@bryk @f-higashi I can do it on Monday, because till end of the week I'm on sick leave.

@bryk
Copy link
Contributor

bryk commented Mar 2, 2016

@f-higashi

Try:

  • 'godep restore ./src/app/backend'
  • Then go get ... deps that you want to update
  • 'godep save ./src/app/backend'

@f-higashi
Copy link
Contributor Author

Thanks for information.
Sorry. My repository path and GOPATH was wrong.

@f-higashi f-higashi force-pushed the validation-for-container branch 2 times, most recently from 9c3da0c to cc40292 Compare March 3, 2016 05:38
@f-higashi
Copy link
Contributor Author

Hmm.
Travis build does not start.
In my repository travis build works.

@bryk
Do you have an idea?
or
Can you cancel the following build? This build process task is broken?

@bryk
Copy link
Contributor

bryk commented Mar 3, 2016

I've cancelled the build.

@bryk
Copy link
Contributor

bryk commented Mar 3, 2016

Let me know when this is ready for review.

@f-higashi f-higashi force-pushed the validation-for-container branch from cc40292 to 93e011e Compare March 3, 2016 08:01
@f-higashi
Copy link
Contributor Author

Thank you to cancel jobs.
But travis build does not start too.
Hmm..

@bryk
Copy link
Contributor

bryk commented Mar 3, 2016

Hmm.... I dont know. Maybe drop this PR and create a new one?

@f-higashi
Copy link
Contributor Author

Yes.
It's better.
Please cancel existing build job.

@f-higashi f-higashi closed this Mar 3, 2016
@f-higashi
Copy link
Contributor Author

After closing this pull request, the build started...
It's strange.
I open this.

@f-higashi f-higashi reopened this Mar 3, 2016
@f-higashi
Copy link
Contributor Author

After reopen, new build is registered and stopped.
I'll create new pull request.

@f-higashi f-higashi closed this Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants