Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations #5625

Closed
fangweilovelife opened this issue Oct 13, 2020 · 13 comments
Closed

Update translations #5625

fangweilovelife opened this issue Oct 13, 2020 · 13 comments
Labels
kind/i18n Categorize issue or PR as related to i18n. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@fangweilovelife
Copy link

Environment
Installation method:
Kubernetes version: v1.19.0
Dashboard version: v2.0.4
Operating system: centos
Node.js version ('node --version' output): v12.19.0
Go version ('go version' output):
Steps to reproduce
Observed result

image

Expected result

all be chinese

Comments

i have edit deployment.yml
like this
image
and tried <value: zh/zh-CN> didn't work

@fangweilovelife fangweilovelife added the kind/bug Categorizes issue or PR as related to a bug. label Oct 13, 2020
@floreks
Copy link
Member

floreks commented Oct 13, 2020

Language is based on your browser locale and presented Accept-Language request header. Recognized codes are defined here. ACCEPT_LANGUAGE env var should override it. You can also try clearing the cache and removing all cookies. If only some strings are localized then it might be our localization that needs an update. There were some major changes and some of the localization might have been lost.

UPDATE

From what I see our localization files indeed have lost some translated strings. Can some of our translators take a look and update it when they have some time?

@hwdef @zehuaiWANG @tanjunchen @shu-mutou @gochist

Feel free to call some more people that were responsible for providing previous translations.

@floreks floreks added kind/i18n Categorize issue or PR as related to i18n. and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 13, 2020
@floreks floreks changed the title how to change the dashborad display language Update translations Oct 13, 2020
@floreks floreks added language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Oct 13, 2020
@hwdef
Copy link
Member

hwdef commented Oct 13, 2020

in #4705, translator decided that some words would not be translated, such as pod and service, If you have other suggestions, please discuss with us.

But your browser is indeed incorrect, please try to clear the cache. I will also try to reproduce this problem.

@floreks I will check for missing translated strings. The translation will be updated in a day or two.

@shu-mutou
Copy link
Contributor

shu-mutou commented Oct 14, 2020

At first, please see https://github.com/kubernetes/dashboard/blob/master/docs/developer/internationalization.md in detail. We don't support zh as a result of long discussions. You can use zh-CN, zh-TW or zh-HK for Chinese and these codes will be replaced at here
Each translation underneeth in i18n directory has OWNERS who are responsible in its translation. Please ask them for each translation.

@fangweilovelife
Copy link
Author

my chrome version :85.0.4183.121(release) (64 位)

And my language settings like this:
move Chinese to the top

image

And this is requst headers:

image

I have deleted cache & cookies , remove the env arg from the deployment.yaml, restart pod. but it didn't work

the result is :
image

and i see dashborad v1.10.0 , most words have been translated

image

@shu-mutou
Copy link
Contributor

shu-mutou commented Oct 14, 2020

Also, each language team has each policy about whether k8s object name should be translated or not. So this issue relates Chinese traslation team.

But un-translated words are increased now.
@headcr4sh @kgroschoff @mkorbi @feloy @gochist @seokho-son @chenrui333 @zehuaiWANG @hwdef @tanjunchen Please update your translations. Thanks!

@hwdef
Copy link
Member

hwdef commented Oct 14, 2020

@EvansFW
Thanks for you replay ,I reproduced the problem, it's not a bug, it's due to a missing translation.
I will update these translation.

But honestly, it wouldn't change much. Proper nouns will not be translated.

@zehuaiWANG
Copy link
Contributor

@EvansFW According to issue #4705 , the word such like 'namespace', 'node' will no be translated.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 11, 2021
@headcr4sh
Copy link
Contributor

The German translation (DE) has been updated in PR #5672.
All technical Kubernetes-specific terms should now be in English without a translation.

/remove-language de

@maciaszczykm
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 22, 2021
@shu-mutou
Copy link
Contributor

/close
If we need translation work for a new release, creates a new issue and manages it there.

@k8s-ci-robot
Copy link
Contributor

@shu-mutou: Closing this issue.

In response to this:

/close
If we need translation work for a new release, creates a new issue and manages it there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/i18n Categorize issue or PR as related to i18n. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

9 participants