Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run as a cluster-service? #565

Closed
colemickens opened this issue Mar 22, 2016 · 1 comment
Closed

Run as a cluster-service? #565

colemickens opened this issue Mar 22, 2016 · 1 comment

Comments

@colemickens
Copy link
Contributor

Should this be run as a cluster service?

If the metadata for the RC/Service were annotated with kubernetes.io/cluster-service: "true" then it would be treated as a cluster-service, and would appear in the output for kubectl cluster-info.
@bryk
Copy link
Contributor

bryk commented Mar 24, 2016

Yeah, makes total sense. This is already done for addon configuration [0], but not in the install guide here. Will fix.

[0] https://github.com/kubernetes/kubernetes/blob/fe269474ca0371a9fc1937046d029445898abd44/cluster/addons/dashboard/dashboard-service.yaml

bryk added a commit to bryk/dashboard that referenced this issue Mar 24, 2016
@bryk
Add kubernetes.io/cluster-service: "true" label to deploy files
e46ad08 
Fixes kubernetes#565
@bryk bryk mentioned this issue Mar 24, 2016
Merged
bryk added a commit to bryk/dashboard that referenced this issue Mar 25, 2016
@bryk
Add kubernetes.io/cluster-service: "true" label to deploy files
3ae1285 
Fixes kubernetes#565
@bryk bryk closed this as completed in #570 Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colemickens @bryk