delete in dashboard does not cascade

[puja108]

Issue details

When deleting a deployment/rc/rs in dashboard the delete does not cascade like it does with kubectl delete. I'd say the cascading should be the expected behavior as it is also the default with kubectl.

Environment

Dashboard version: 1.1.0
Kubernetes version: 1.2.5
Operating system:
Node.js version:
Go version:

Steps to reproduce

1. Delete any deployment, rc, or rs

Observed result

The delete does not cascade to resources managed by the deleted resource.

Expected result

Cascading delete like with kubectl delete (default behavior), i.e. deployment->rs->pods; rs->pods; rc->pods

Comments

[floreks]

I've encountered same issue lately. We have to rethink our generic approach to delete, because it leaves orphaned resources on the cluster.

cc @bryk

[bryk]

I definitely agree. We need to wait until this is implemented on the server side: kubernetes/kubernetes#19054

Otherwise, it is us duplicating kubectl and apiserver work.

Thoughts?

[floreks]

Nice. Didn't know about that. We should definitely wait for kubernetes to get this feature.

[puja108]

Same here, looks like we should wait then, also good discussion about what the default should be. For me the default for UI should be same as for kubectl to have a coherent UX across CLI and UI.

[floreks]

For me the default for UI should be same as for kubectl to have a coherent UX across CLI and UI.

That's our goal :)

[bgrant0607]

cc @caesarxuchao

[caesarxuchao]

In the upcoming 1.4 release, server-side cascading deletion of rc and rs is possible, dashboard just needs to send to apiserver a deletion request with DeleteOptions.OrphanDependents=false.

We will work on the other use cases in 1.5.

[floreks]

Great! We should support this.

cc @bryk @maciaszczykm

[bryk]

@caesarxuchao Cool, thanks.

Will we get cascade delete for free for future use cases when we just send DeleteOptions.OrphanDependents=false with all delete requests?

[caesarxuchao]

@bryk what are the future use cases you have in mind? We will support cascading deletion for Deployment in the future.

[puja108]

Can't test right now, but Jobs would be good.

On a sidenote: Does deletion of namespaces (I'd guess that always incl all their resources) work in Dashboard?

[bryk]

@puja108 We dont (yet) support deletion/modification of cluster admin resources. It is challenging, as you already noticed, so we want to tackle this only when we have time to do this right.

[bryk]

@caesarxuchao

what are the future use cases you have in mind? We will support cascading deletion for Deployment in the future.

Yes, cases like cascade delete for Deployments or Namespaces.

[maciaszczykm]

Will track it from #1570.