-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added tooltips to event timestamps #3643
added tooltips to event timestamps #3643
Conversation
/assign @eloyekunle |
@DanielUche: GitHub didn't allow me to assign the following users: eloyekunle. Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @eloyekunle |
@DanielUche: GitHub didn't allow me to assign the following users: eloyekunle. Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment, should be a quick change. Rest looked good and that change worked on my machine. :)
Thanks!
src/app/frontend/common/components/resourcelist/event/template.html
Outdated
Show resolved
Hide resolved
src/app/frontend/common/components/resourcelist/event/template.html
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3643 +/- ##
==========================================
- Coverage 46.82% 46.81% -0.02%
==========================================
Files 165 165
Lines 7763 7763
Branches 24 24
==========================================
- Hits 3635 3634 -1
- Misses 3906 3907 +1
Partials 222 222
Continue to review full report at Codecov.
|
<mat-cell *matCellDef="let event"> | ||
<mat-cell *matCellDef="let event" | ||
matTooltip="{{event.lastSeen | date:'medium'}}" | ||
matTooltipPosition="above"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We keep the default position in other places. Remove it and we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielUche Ping! Make that small change and we can merge this in. :) Thanks!
Applied the changes. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DanielUche, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue doesn't completely fix #3631, although it is a step in the right direction. |
There is a formatting issue. I will close it as @DanielUche is not responding. Please reopen if you are willing to apply required changes, then we can merge. /close |
@maciaszczykm: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds