Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tooltips to event timestamps #3643

Closed

Conversation

DanielUche
Copy link

@DanielUche DanielUche commented Mar 9, 2019

This PR adds

  1. Timestamp tooltips to the events table.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2019
@k8s-ci-robot k8s-ci-robot requested review from bryk and cheld March 9, 2019 18:10
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2019
@DanielUche
Copy link
Author

DanielUche commented Mar 9, 2019

/assign @eloyekunle

@k8s-ci-robot
Copy link
Contributor

@DanielUche: GitHub didn't allow me to assign the following users: eloyekunle.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign eloyekunle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DanielUche
Copy link
Author

/assign @eloyekunle

@k8s-ci-robot
Copy link
Contributor

@DanielUche: GitHub didn't allow me to assign the following users: eloyekunle.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @eloyekunle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jeefy jeefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment, should be a quick change. Rest looked good and that change worked on my machine. :)

Thanks!

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #3643 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3643      +/-   ##
==========================================
- Coverage   46.82%   46.81%   -0.02%     
==========================================
  Files         165      165              
  Lines        7763     7763              
  Branches       24       24              
==========================================
- Hits         3635     3634       -1     
- Misses       3906     3907       +1     
  Partials      222      222
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a6895...e9c53bf. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2019
<mat-cell *matCellDef="let event">
<mat-cell *matCellDef="let event"
matTooltip="{{event.lastSeen | date:'medium'}}"
matTooltipPosition="above">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep the default position in other places. Remove it and we can merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielUche Ping! Make that small change and we can merge this in. :) Thanks!

@maciaszczykm
Copy link
Member

Applied the changes.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DanielUche, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2019
@eloyekunle
Copy link
Contributor

eloyekunle commented Apr 5, 2019

The issue doesn't completely fix #3631, although it is a step in the right direction.
The goal is to add these tooltips everywhere a time is displayed on the dashboard.

@maciaszczykm
Copy link
Member

There is a formatting issue. I will close it as @DanielUche is not responding. Please reopen if you are willing to apply required changes, then we can merge.

/close

@k8s-ci-robot
Copy link
Contributor

@maciaszczykm: Closed this PR.

In response to this:

There is a formatting issue. I will close it as @DanielUche is not responding. Please reopen if you are willing to apply required changes, then we can merge.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants