Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs for dashboard arguments #4164

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

shu-mutou
Copy link
Contributor

Also, cleanup descriptions for dashboard --help.

e.g. remove description for default value like "Default: ~" to prevent duplicating with default value printed out by pflag.

Related to #4008

Also, cleanup descriptions for `dashboard --help`.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from floreks and jeefy August 5, 2019 07:58
@maciaszczykm
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #4164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4164   +/-   ##
=======================================
  Coverage   46.19%   46.19%           
=======================================
  Files         194      194           
  Lines        8999     8999           
  Branches       83       83           
=======================================
  Hits         4157     4157           
  Misses       4586     4586           
  Partials      256      256

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d783fb...12778e4. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit f09b3d6 into kubernetes:master Aug 5, 2019
@shu-mutou shu-mutou deleted the docs-arguments branch August 6, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants