Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs for release procedures #4169

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

shu-mutou
Copy link
Contributor

@shu-mutou shu-mutou commented Aug 6, 2019

Also, add descriptions for GO111MODULE into Getting started and Dependency management

Related to #4008

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from cheld and mhenc August 6, 2019 05:57
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #4169 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4169      +/-   ##
==========================================
+ Coverage   46.18%   46.19%   +0.01%     
==========================================
  Files         194      194              
  Lines        8999     8999              
  Branches       83       83              
==========================================
+ Hits         4156     4157       +1     
+ Misses       4587     4586       -1     
  Partials      256      256
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 90.9% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4575bfb...4cffd18. Read the comment docs.

@shu-mutou
Copy link
Contributor Author

go mod sometimes timeouts in downloading modules. 🤔

@shu-mutou
Copy link
Contributor Author

Issue about downloading module by go mod will fixed by #4170 .

Copy link
Member

@jeefy jeefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick things to address, PTAL :)

@@ -8,6 +8,7 @@ Make sure the following software is installed and added to the $PATH variable:

* Docker 1.10+ ([installation manual](https://docs.docker.com/engine/installation/linux/docker-ce/ubuntu/))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change this to Docker 1.13.1 since that's the minimum docker version in K8s right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -1,6 +1,35 @@
# Release procedures

___It will be moved soon, for now you can [visit Wiki](https://github.com/kubernetes/dashboard/wiki/Release-procedures).___
## Official releases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a step (or two) missing that involves building and pushing the container image to the official repo(s) /cc @maciaszczykm @floreks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find the procedures to build and push container image for official release. Could you tell me the procedures or follow up this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now there are no manual steps required to push the images. Everything is done by the Travis after successful TAG build.


There is no need to do anything at all after everything was set up and now the whole process is automated.

On every successful master build CI provides development releases, that are pushed to [`kubernetesdashboarddev/dashboard*`](https://hub.docker.com/r/kubernetesdashboarddev) repositories. Each build produces one image for each architecture. The images are tagged with SHA of the commit they were built at and `head` tag is updated to reference the newest one.
Copy link
Member

@floreks floreks Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since v2 images with commit SHA are no longer being pushed. Only head images are.

Also, add descriptions for `GO111MODULE` into `Getting started` and `Dependency management`
And bump docker version requisites to 1.13.1+.
@floreks
Copy link
Member

floreks commented Aug 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9fb529e into kubernetes:master Aug 8, 2019
@shu-mutou shu-mutou deleted the docs-releases branch August 8, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants