-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate docs for release procedures #4169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4169 +/- ##
==========================================
+ Coverage 46.18% 46.19% +0.01%
==========================================
Files 194 194
Lines 8999 8999
Branches 83 83
==========================================
+ Hits 4156 4157 +1
+ Misses 4587 4586 -1
Partials 256 256
Continue to review full report at Codecov.
|
|
Issue about downloading module by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple quick things to address, PTAL :)
docs/developer/getting-started.md
Outdated
@@ -8,6 +8,7 @@ Make sure the following software is installed and added to the $PATH variable: | |||
|
|||
* Docker 1.10+ ([installation manual](https://docs.docker.com/engine/installation/linux/docker-ce/ubuntu/)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change this to Docker 1.13.1 since that's the minimum docker version in K8s right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -1,6 +1,35 @@ | |||
# Release procedures | |||
|
|||
___It will be moved soon, for now you can [visit Wiki](https://github.com/kubernetes/dashboard/wiki/Release-procedures).___ | |||
## Official releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a step (or two) missing that involves building and pushing the container image to the official repo(s) /cc @maciaszczykm @floreks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find the procedures to build and push container image for official release. Could you tell me the procedures or follow up this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now there are no manual steps required to push the images. Everything is done by the Travis after successful TAG build.
115998b
to
8f6fb2e
Compare
docs/developer/release-procedures.md
Outdated
|
||
There is no need to do anything at all after everything was set up and now the whole process is automated. | ||
|
||
On every successful master build CI provides development releases, that are pushed to [`kubernetesdashboarddev/dashboard*`](https://hub.docker.com/r/kubernetesdashboarddev) repositories. Each build produces one image for each architecture. The images are tagged with SHA of the commit they were built at and `head` tag is updated to reference the newest one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since v2 images with commit SHA are no longer being pushed. Only head
images are.
Also, add descriptions for `GO111MODULE` into `Getting started` and `Dependency management` And bump docker version requisites to 1.13.1+.
8f6fb2e
to
4cffd18
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also, add descriptions for
GO111MODULE
intoGetting started
andDependency management
Related to #4008