-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'Scale' subresource for CRDs #4195
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4195 +/- ##
=========================================
Coverage ? 45.95%
=========================================
Files ? 198
Lines ? 9298
Branches ? 105
=========================================
Hits ? 4273
Misses ? 4765
Partials ? 260
Continue to review full report at Codecov.
|
This is ready for review, PTAL. /assign @jeefy @maciaszczykm @floreks |
Please rebase. |
d3b2a18
to
e78f5fe
Compare
Rebased. |
src/app/frontend/common/components/list/column/menu/component.ts
Outdated
Show resolved
Hide resolved
d3624c3
to
e1e1848
Compare
e1e1848
to
c50b960
Compare
src/app/frontend/common/components/actionbars/scaledefault/component.ts
Outdated
Show resolved
Hide resolved
Tested locally. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloyekunle, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Backend implementation via
k8s.io/client-go/scale
currently unable to work with cluster-scoped resources. Tracking issue: kubernetes/kubernetes#81380Closes #4167