Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for create and delete replication controller #429

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Add integration test for create and delete replication controller #429

merged 1 commit into from
Feb 29, 2016

Conversation

maciaszczykm
Copy link
Member

Added integration test for create and delete replication controller. Connected to #346. Rebased with @floreks' branch to make code more consistent.

Review on Reviewable

@codecov-io
Copy link

Current coverage is 81.76%

Merging #429 into master will not affect coverage as of 4ce5acb

@@            master    #429   diff @@
======================================
  Files           77      77       
  Stmts          625     625       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            511     511       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 4ce5acb

Powered by Codecov. Updated on successful CI builds.

@bryk
Copy link
Contributor

bryk commented Feb 29, 2016

:lgtm:, we need a rebase though.


Reviewed 3 of 8 files at r1, 1 of 2 files at r2.
Review status: 4 of 9 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


build/protractor.conf.js, line 71 [r2] (raw file):
Hmm.... Revert? I believe it is already changed on HEAD


Comments from the review on Reviewable.io

@maciaszczykm
Copy link
Member Author

Rebased. PTAL


Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


build/protractor.conf.js, line 71 [r2] (raw file):
Fixed after rebase.


Comments from the review on Reviewable.io

@bryk
Copy link
Contributor

bryk commented Feb 29, 2016

Travis still fails. Fix?


Reviewed 1 of 8 files at r1, 1 of 2 files at r2, 1 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@maciaszczykm
Copy link
Member Author

Wow, it seems, that it was random issue on Travis. Didn't expect that in integration tests, but it worked locally and now it's fixed after commit empty ammend.

@bryk
Copy link
Contributor

bryk commented Feb 29, 2016

Travis is a little bit flaky , I know. We should fix this once it starts hurting us.


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

bryk added a commit that referenced this pull request Feb 29, 2016
Add integration test for create and delete replication controller
@bryk bryk merged commit fa0e2d0 into kubernetes:master Feb 29, 2016
@bryk bryk deleted the create-and-delete-rc-test branch February 29, 2016 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants