Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress E2E test for create resource from input #4436

Closed
wants to merge 4 commits into from

Conversation

anshulahuja98
Copy link
Contributor

@anshulahuja98 anshulahuja98 commented Oct 19, 2019

Work towards #4153

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anshulahuja98
To complete the pull request process, please assign danielromlein
You can assign the PR to them by writing /assign @danielromlein in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2019
@k8s-ci-robot k8s-ci-robot added language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Oct 19, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #4436 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4436      +/-   ##
==========================================
+ Coverage   46.66%   46.71%   +0.04%     
==========================================
  Files         200      200              
  Lines        9379     9377       -2     
  Branches      107      107              
==========================================
+ Hits         4377     4380       +3     
+ Misses       4729     4723       -6     
- Partials      273      274       +1
Impacted Files Coverage Δ
src/app/backend/errors/errors.go 20.95% <0%> (-0.21%) ⬇️
src/app/backend/errors/handler.go 9.83% <0%> (+0.15%) ⬆️
...pp/backend/integration/metric/heapster/selector.go 71.42% <0%> (+1.11%) ⬆️
...app/backend/integration/metric/sidecar/selector.go 71.42% <0%> (+1.11%) ⬆️
src/app/backend/sync/secret.go 73.26% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab77f91...e042a1b. Read the comment docs.

@anshulahuja98
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@atoato88
Copy link
Contributor

/uncc
I'm a reviewer in i18n/ja/ only.
Sorry that I cannot review js code on this PR.

@k8s-ci-robot k8s-ci-robot removed the request for review from atoato88 October 22, 2019 23:34
@floreks floreks removed the request for review from feloy October 23, 2019 06:57
@anshulahuja98
Copy link
Contributor Author

/close
Closed till
#4435
doesn't lay the groundwork for cypress tests.

@k8s-ci-robot
Copy link
Contributor

@anshulahuja98: Closed this PR.

In response to this:

/close
Closed till
#4435
doesn't lay the groundwork for cypress tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants