Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker build pipeline always use clean env and actaully work #479

Merged
merged 1 commit into from
Mar 2, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Mar 2, 2016

Previously it didn't always work because my local env was overriding
what was previously baked into image. Now the image bases only on source
code and is brand new each time.

It is also a lot faster when dockerignore excludes more files.

This also moves Dockerfile to build/ directory to avoid confusion from developers about its purpose.

Review on Reviewable

@bryk
Copy link
Contributor Author

bryk commented Mar 2, 2016

@floreks Can you review?

@codecov-io
Copy link

Current coverage is 82.29%

Merging #479 into master will not affect coverage as of 6c42b66

@@            master    #479   diff @@
======================================
  Files           79      79       
  Stmts          644     644       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            530     530       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 6c42b66

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 2, 2016

That's really nice. :lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


build/Dockerfile, line 23 [r1] (raw file):
Python is not installed anymore


Comments from the review on Reviewable.io

Previously it didn't always work because my local env was overriding
what was previously baked into image. Now the image bases only on source
code and is brand new each time.

It is also a lot faster when dockerignore excludes more files.
@bryk
Copy link
Contributor Author

bryk commented Mar 2, 2016

Merging.


Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

bryk added a commit that referenced this pull request Mar 2, 2016
Make docker build pipeline always use clean env and actaully work
@bryk bryk merged commit 040ab59 into kubernetes:master Mar 2, 2016
@bryk bryk deleted the docker-build branch November 24, 2016 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants