update documentation for building on darwin

[ivelichkovich]

otherwise you can't build docker when working in a darwin environment, you get incompatible architectures from go build.

[k8s-ci-robot]

Welcome @ivelichkovich!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[ivelichkovich]

/assign @ianlewis

[codecov]

Codecov Report

Merging #4796 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4796      +/-   ##
==========================================
- Coverage   45.43%   45.42%   -0.02%     
==========================================
  Files         214      214              
  Lines        9977     9977              
  Branches       94       94              
==========================================
- Hits         4533     4532       -1     
- Misses       5180     5181       +1     
  Partials      264      264

Impacted Files	Coverage Δ
...p/backend/integration/metric/common/aggregation.go	89.09% <0%> (-1.82%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2deefb1...c8644cd. Read the comment docs.

[floreks]

Add that before npm run build block.

[ivelichkovich]

Moved it, I can move it around more or change the text if needed

[floreks]

This part should be after export GOOS=linux

[ivelichkovich]

ah yeah that makes more sense, updated

[ivelichkovich]

while we're at it, is there a faster way to build this docker image? If I'm only changing the go for example, the frontend takes ages to build, is there a way I can just manually run go build and build a docker container from that?

[ivelichkovich]

Also what should I do about the test coverage?

[floreks]

while we're at it, is there a faster way to build this docker image? If I'm only changing the go for example, the frontend takes ages to build, is there a way I can just manually run go build and build a docker container from that?

We do not have separate task for that, but you could manually compile backend binary, replace it in the dist directory and run only gulp docker-image:head:cross. I don't see why you would build the image on your own frequently. You develop on serve and then do the final test on prod. That should be enough most of the time.

Also what should I do about the test coverage?

Don't worry about that. Those calculations have a margin of error.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, ivelichkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment