Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bc dependence #4816

Merged
merged 1 commit into from
Jan 22, 2020
Merged

add bc dependence #4816

merged 1 commit into from
Jan 22, 2020

Conversation

daixiang0
Copy link
Contributor

Signed-off-by: Xiang Dai 764524258@qq.com

Without bc, build would fail:

...
Copying locales file to backend dist dirs

Copying Dockerfile to backend dist dirs
./aio/scripts/build.sh: line 126: bc: command not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR! kubernetes-dashboard@2.0.0-beta4 build: ./aio/scripts/build.sh
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the kubernetes-dashboard@2.0.0-beta4 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/2020-01-20T09_59_52_893Z-debug.log

Signed-off-by: Xiang Dai <764524258@qq.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2020
@daixiang0 daixiang0 requested a review from shu-mutou January 22, 2020 02:37
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #4816 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4816      +/-   ##
==========================================
+ Coverage   45.42%   45.43%   +0.01%     
==========================================
  Files         214      214              
  Lines        9977     9977              
  Branches       94       94              
==========================================
+ Hits         4532     4533       +1     
+ Misses       5181     5180       -1     
  Partials      264      264
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 90.9% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3568526...e39e122. Read the comment docs.

@shu-mutou
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daixiang0, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit d22c869 into kubernetes:master Jan 22, 2020
@daixiang0 daixiang0 deleted the bc branch January 22, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants