Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cookies sameSite to strict and use secure cookies #4877

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Set cookies sameSite to strict and use secure cookies #4877

merged 1 commit into from
Feb 6, 2020

Conversation

maciaszczykm
Copy link
Member

Fixes #4845.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2020
@k8s-ci-robot k8s-ci-robot requested review from bryk and mhenc February 6, 2020 11:38
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@floreks
Copy link
Member

floreks commented Feb 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #4877 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4877      +/-   ##
==========================================
- Coverage    45.4%   45.39%   -0.02%     
==========================================
  Files         214      214              
  Lines        9983     9983              
  Branches       94       94              
==========================================
- Hits         4533     4532       -1     
- Misses       5185     5186       +1     
  Partials      265      265
Impacted Files Coverage Δ
.../frontend/common/services/global/authentication.ts 40.32% <0%> (ø) ⬆️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e12d9...ec296e5. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 938a1bd into kubernetes:master Feb 6, 2020
@maciaszczykm maciaszczykm deleted the fix/secure-cookies branch February 6, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'skipLoginPage' cookie set with SameSite=None but not Secure
3 participants