Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to tour on zerostate and deploy views #497

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Add links to tour on zerostate and deploy views #497

merged 1 commit into from
Mar 7, 2016

Conversation

maciaszczykm
Copy link
Member

Implements #476.

image

image

Review on Reviewable

@codecov-io
Copy link

Current coverage is 83.62%

Merging #497 into master will decrease coverage by -0.02% as of e445e1c

@@            master    #497   diff @@
======================================
  Files           84      84       
  Stmts          697     696     -1
  Branches         0       0       
  Methods          0       0       
======================================
- Hit            583     582     -1
  Partial          0       0       
  Missed         114     114

Review entire Coverage Diff as of e445e1c

Powered by Codecov. Updated on successful CI builds.

@maciaszczykm
Copy link
Member Author

Updated. PTAL

@maciaszczykm
Copy link
Member Author

Updated. Removed the Kubernetes Darhboard, because it moved external link icon to another line and it looked badly.

bryk
bryk reviewed Mar 7, 2016
View reviewed changes
src/app/frontend/deploy/deploy.html
@@ -28,6 +28,12 @@ <h3 class="md-headline kd-deploy-form-title">Deploy a Containerized App</h3>
Upload a YAML or JSON file
</md-radio-button>
</md-radio-group>
<kd-user-help>
To learn more,
<a href="http://kubernetes.io/v1.1/docs/user-guide/ui.html" target="_blank">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.... The link here. It shows the old UI. See this announcement: https://groups.google.com/forum/#!topic/kubernetes-dev/UedwIYb-fHg

I think the correct link for 1.2 will be: http://kubernetes.github.io/docs/user-guide/ui/

What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please update.

@maciaszczykm
Copy link
Member Author

Updated. PTAL

@bryk
Copy link
Contributor

bryk commented Mar 7, 2016

LGTM. Will do final checs

bryk added a commit that referenced this pull request Mar 7, 2016
@bryk
Merge pull request #497 from maciaszczykm/links-update
24b3712 
Add links to tour on zerostate and deploy views
@bryk bryk merged commit 24b3712 into kubernetes:master Mar 7, 2016
@bryk bryk deleted the links-update branch March 7, 2016 12:18
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
@skdwriting
Merge pull request kubernetes#497 from anvithks/restore-fix
e57c54f 
Fixed content type issue with signature generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maciaszczykm @codecov-io @bryk @googlebot