Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create form #5002

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Fix create form #5002

merged 1 commit into from
Mar 12, 2020

Conversation

floreks
Copy link
Member

@floreks floreks commented Mar 12, 2020

Fixes #4999

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2020
@k8s-ci-robot k8s-ci-robot requested review from mhenc and olekzabl March 12, 2020 10:50
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #5002 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5002      +/-   ##
=========================================
+ Coverage   45.36%   45.4%   +0.04%     
=========================================
  Files         214     214              
  Lines       10000   10055      +55     
  Branches       97      96       -1     
=========================================
+ Hits         4536    4565      +29     
- Misses       5198    5223      +25     
- Partials      266     267       +1
Impacted Files Coverage Δ
src/app/backend/client/manager.go 56.01% <0%> (-1.19%) ⬇️
src/app/backend/resource/deployment/deploy.go 44.44% <0%> (-1.02%) ⬇️
src/app/frontend/common/pipes/safehtml.ts 42.85% <0%> (-28.58%) ⬇️
src/app/backend/handler/localehandler.go 56.94% <0%> (-5.77%) ⬇️
src/app/frontend/common/pipes/memoryformatter.ts 26.66% <0%> (-4.59%) ⬇️
src/app/frontend/common/pipes/coreformatter.ts 26.66% <0%> (-4.59%) ⬇️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️
.../app/frontend/common/components/graph/component.ts 63.38% <0%> (-0.51%) ⬇️
src/app/frontend/shared.module.ts 100% <0%> (ø) ⬆️
src/app/frontend/login/component.ts 81.69% <0%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675f106...46df6c7. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit c461975 into kubernetes:master Mar 12, 2020
@floreks floreks deleted the fix/create branch April 13, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.0.0-rc5 failed to create storageclass with "the server could not find the requested resource""
3 participants