Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable deploy from file tests until they're fixed. #501

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Mar 8, 2016

Partially addresses #494

Review on Reviewable

@bryk
Copy link
Contributor Author

bryk commented Mar 8, 2016

@f-higashi @maciaszczykm Can you review?

It is important now for us to have green tests, so I'm doing this.

@codecov-io
Copy link

Current coverage is 83.62%

Merging #501 into master will not affect coverage as of 9374cd3

@@            master    #501   diff @@
======================================
  Files           84      84       
  Stmts          696     696       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            582     582       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 9374cd3

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 8, 2016

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@maciaszczykm
Copy link
Member

:lgtm:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@f-higashi
Copy link
Contributor

I checked failed log.
I don't think it is related to #494.
Maybe It is related to the sauce temporary storage.
https://support.saucelabs.com/customer/portal/questions/14330476-file-upload-or-download-

But I agree with skipping these test now.

:lgtm:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

bryk added a commit that referenced this pull request Mar 8, 2016
Disable deploy from file tests until they're fixed.
@bryk bryk merged commit ef6cecf into kubernetes:master Mar 8, 2016
@bryk bryk deleted the disable-broken-tests branch March 8, 2016 09:31
anvithks added a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
* Fixed the null prefix in object name issue

* Fixed issue of file not uploading to folder.

* Optimized the conditional

Co-authored-by: Sanil Kumar <skdsanil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants