Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some zh translate #5025

Merged
merged 3 commits into from
Mar 24, 2020
Merged

fix some zh translate #5025

merged 3 commits into from
Mar 24, 2020

Conversation

helight
Copy link
Contributor

@helight helight commented Mar 23, 2020

fix some zh translate

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @helight!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/zh Updates or issues for Chinese translations. labels Mar 23, 2020
@zehuaiWANG
Copy link
Contributor

thanks for @helight 's contribution, most of them look good. And I think it‘s better to keep the translation of “Name” consistent.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #5025 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
- Coverage   45.42%   45.38%   -0.04%     
==========================================
  Files         214      214              
  Lines       10078    10078              
  Branches      100      100              
==========================================
- Hits         4578     4574       -4     
- Misses       5232     5237       +5     
+ Partials      268      267       -1
Impacted Files Coverage Δ
src/app/backend/sync/secret.go 70.29% <0%> (-2.98%) ⬇️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e26084...9fccdc7. Read the comment docs.

i18n/zh/messages.zh.xlf Show resolved Hide resolved
i18n/zh/messages.zh.xlf Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #5025 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
- Coverage   45.42%   45.41%   -0.01%     
==========================================
  Files         214      214              
  Lines       10078    10078              
  Branches      100      100              
==========================================
- Hits         4578     4577       -1     
- Misses       5232     5233       +1     
  Partials      268      268
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e26084...4afc9c6. Read the comment docs.

@hwdef
Copy link
Member

hwdef commented Mar 23, 2020

/approve
Thanks for your contribution.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@tanjunchen
Copy link
Member

/LGTM
Thanks for your contribution.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: helight, hwdef, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zehuaiWANG
Copy link
Contributor

[0] level=warning msg="[runner] Can't run linter goanalysis_metalinter: ineffassign: analysis skipped: errors in package: [/home/travis/build/kubernetes/dashboard/src/app/backend/plugin/client/clientset/versioned/clientset.go:1: no such file or directory /home/travis/build/kubernetes/dashboard/src/app/backend/plugin/client/clientset/versioned/doc.go:1: no such file or directory]"
[0] level=error msg="Running error: ineffassign: analysis skipped: errors in package: [/home/travis/build/kubernetes/dashboard/src/app/backend/plugin/client/clientset/versioned/clientset.go:1: no such file or directory /home/travis/build/kubernetes/dashboard/src/app/backend/plugin/client/clientset/versioned/doc.go:1: no such file or directory]"

@floreks @shu-mutou hi~ I found out that CI has such problem, it seems that it is not caused by this PR, but I am not familiar with this one, could you help to find out why this happened?

@tanjunchen
Copy link
Member

/retest

@shu-mutou
Copy link
Contributor

shu-mutou commented Mar 24, 2020

@zehuaiWANG I've done Restart job on travis UI and passed the test. The job will be done successfully soon.

@k8s-ci-robot k8s-ci-robot merged commit 7b24fe1 into kubernetes:master Mar 24, 2020
@helight helight deleted the zh-translate branch March 24, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants