Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor go code and fix link to go report card #504

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Refactor go code and fix link to go report card #504

merged 1 commit into from
Mar 8, 2016

Conversation

maciaszczykm
Copy link
Member

Continuation of #500. Didn't resolve issues like:

Line 136: warning: can probably use "var result []Event" instead (golint)

Because simple change of declaration break tests.

Moreover, issues like:

Line 76: warning: struct field CpuRequirement should be CPURequirement (golint)

Weren't fixed, because it's probably too much changes.

Review on Reviewable

@floreks floreks self-assigned this Mar 8, 2016
@codecov-io
Copy link

Current coverage is 83.59%

Merging #504 into master will not affect coverage as of ea14406

@@            master    #504   diff @@
======================================
  Files           84      84       
  Stmts          695     695       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            581     581       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of ea14406

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 8, 2016

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


src/app/backend/deploy.go, line 32 [r1] (raw file):
for the/a description?


src/app/backend/heapsterclient.go, line 32 [r1] (raw file):
InClusterHeapsterClient is an in-cluster


Comments from the review on Reviewable.io

@floreks
Copy link
Member

floreks commented Mar 8, 2016

Small comments. Rest :lgtm:


Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from the review on Reviewable.io

@maciaszczykm
Copy link
Member Author

PTAL

@floreks
Copy link
Member

floreks commented Mar 8, 2016

:lgtm:


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from the review on Reviewable.io

@maciaszczykm
Copy link
Member Author

Review status: all files reviewed at latest revision, 2 unresolved discussions.


src/app/backend/deploy.go, line 32 [r1] (raw file):
Done.


src/app/backend/heapsterclient.go, line 32 [r1] (raw file):
Done.


Comments from the review on Reviewable.io

maciaszczykm added a commit that referenced this pull request Mar 8, 2016
Refactor go code and fix link to go report card
@maciaszczykm maciaszczykm merged commit 8cfcf64 into kubernetes:master Mar 8, 2016
@maciaszczykm maciaszczykm deleted the go-refactoring branch March 8, 2016 13:13
anvithks added a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants