Adds support for showing warning icon in StatefulSet

[Harkishen-Singh]

Signed-off-by: Harkishen Singh harkishensingh@hotmail.com

Fixes: #4205

Explanatory Image:

[k8s-ci-robot]

Welcome @Harkishen-Singh!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[Harkishen-Singh]

/assign @floreks

[floreks]

I'd argue that when desired nr of pods is different than actual number it does not necessarily mean there is something wrong with it. It might be upscaling/downscaling. This case is definitely not a warning, more like pending.

[codecov]

Codecov Report

Merging #5055 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5055   +/-   ##
=======================================
  Coverage   45.42%   45.42%           
=======================================
  Files         214      214           
  Lines       10078    10078           
  Branches      100      100           
=======================================
  Hits         4578     4578           
  Misses       5232     5232           
  Partials      268      268           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2c4cc...d05cd78. Read the comment docs.

[Harkishen-Singh]

@floreks sure. I actually implemented that way since I did not any other notable things in response from the API (getData()). So, I thought that the warning symbol should be kind of like an alert that can signify anything different than the desired value (noticed in gke, I think so).

What do you suggest should be the recommended way here? @floreks

[floreks]

Our error state is actually a warning state. If there are warning/error events associated with any resource, an error icon will appear and proper message will be available. I don't think a warning status is needed here.

[Harkishen-Singh]

@floreks does that mean, the green check in 0/1 Pods (previously) is acceptable?

[floreks]

This is weird because 0/1 should mean that there is a pending pod waiting to be created. You can extend the pending/success checks to check for pending pods and if desired/actual pods match. In such case it should show pending status.

[Harkishen-Singh]

Got your point. However, in this case, the pods will forever remain in a pending case. Hence I thought that showing a warning or alert icon will be required, as the issue says.

We should also note that the StatefulSets pie chart in the Workload status shows running:1 even though it is in a pending state. I think you are mentioning to improve this logic of checking?

[Harkishen-Singh]

@floreks updated the logic as per discussion.

[Harkishen-Singh]

@floreks done.

[floreks]

/lgtm

[floreks]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, Harkishen-Singh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment