Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky tests until IE issue is resolved #514

Merged
merged 1 commit into from
Mar 9, 2016

Conversation

floreks
Copy link
Member

@floreks floreks commented Mar 9, 2016

I'd propose to disable tests that fail on IE for now. I've investigated that and explained probable cause of that in #494. We should discuss that in there and find some solution.

@maciaszczykm @batikanu @bryk


This change is Review on Reviewable

@codecov-io
Copy link

Current coverage is 85.99%

Merging #514 into master will not affect coverage as of d5fea1b

@@            master    #514   diff @@
======================================
  Files           95      95       
  Stmts          814     814       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            700     700       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of d5fea1b

Powered by Codecov. Updated on successful CI builds.

@batikanu
Copy link
Contributor

batikanu commented Mar 9, 2016

:lgtm:


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@batikanu
Copy link
Contributor

batikanu commented Mar 9, 2016

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@maciaszczykm
Copy link
Member

We should make master green now and then search for a solution for it. LGTM

floreks pushed a commit that referenced this pull request Mar 9, 2016
Disable flaky tests until IE issue is resolved
@floreks floreks merged commit e321dd0 into kubernetes:master Mar 9, 2016
@floreks floreks deleted the disable-failed-tests branch March 9, 2016 21:35
@bryk
Copy link
Contributor

bryk commented Mar 11, 2016

Yeah, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants