Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display service accounts #5249

Merged
merged 12 commits into from
Jun 18, 2020
Merged

Display service accounts #5249

merged 12 commits into from
Jun 18, 2020

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Jun 10, 2020

Zrzut ekranu 2020-06-18 o 14 24 02

Related to #5232.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2020
@k8s-ci-robot k8s-ci-robot requested review from jeefy and olekzabl June 10, 2020 09:54
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2020
@maciaszczykm maciaszczykm marked this pull request as draft June 18, 2020 08:43
@maciaszczykm maciaszczykm changed the title [WIP] Display service accounts Display service accounts Jun 18, 2020
@maciaszczykm maciaszczykm marked this pull request as ready for review June 18, 2020 12:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2020
@maciaszczykm
Copy link
Member Author

/assign @floreks

@floreks
Copy link
Member

floreks commented Jun 18, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@maciaszczykm maciaszczykm added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #5249 into master will decrease coverage by 0.06%.
The diff coverage is 32.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5249      +/-   ##
==========================================
- Coverage   45.50%   45.43%   -0.07%     
==========================================
  Files         214      214              
  Lines       10109    10201      +92     
  Branches      105      107       +2     
==========================================
+ Hits         4600     4635      +35     
- Misses       5240     5292      +52     
- Partials      269      274       +5     
Impacted Files Coverage Δ
src/app/backend/api/types.go 35.29% <ø> (ø)
src/app/backend/handler/apihandler.go 27.74% <28.57%> (+0.03%) ⬆️
src/app/backend/resource/secret/list.go 37.20% <50.00%> (ø)
...rontend/common/components/resourcelist/groupids.ts 100.00% <100.00%> (ø)
.../app/frontend/common/services/resource/endpoint.ts 80.35% <100.00%> (+0.72%) ⬆️
src/app/frontend/login/component.ts 81.25% <0.00%> (-0.70%) ⬇️
src/app/frontend/index.config.ts 100.00% <0.00%> (ø)
src/app/backend/handler/filter.go 45.45% <0.00%> (ø)
...p/backend/integration/metric/common/aggregation.go 90.90% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9214d...19373dd. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 577f9ff into kubernetes:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants